Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow activesupport3 as well as activesupport4. #63

Closed
wants to merge 1 commit into from

Conversation

jkingdon
Copy link

Either activesupport has what we need, and it seems unnecessary/bad to make
people upgrade from rails3 to rails4 just so they can run
transpec.

With this change, I was able to run transpec on a large rails 3.0 app and it has been working great.

Either one has what we need, and it seems unnecessary/bad to make
people upgrade from rails3 to rails4 just so they can run
transpec.
@jkingdon
Copy link
Author

Hmm, looking into this closer, if one runs transpec as bundle exec transpec instead of transpec, then one will get the error transpec is not part of the bundle. Add it to Gemfile. However, adding it to Gemfile seems to be the wrong solution, with the right one being just not using bundle exec.

So I guess this can be closed, unless there is sometimes a reason to add it to Gemfile.

@yujinakayama
Copy link
Owner

Yeah, basically transpec is intended to be run outside of the project's Bundler context. However, in some cases, it may be added to the Gemfile and should work properly as much as possible. So I'm 👍 for this.

@@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency 'bundler', '~> 1.3'
spec.add_runtime_dependency 'rainbow', '>= 1.99.1', '< 3.0'
spec.add_runtime_dependency 'json', '~> 1.8'
spec.add_runtime_dependency 'activesupport', '~> 4.0'
spec.add_runtime_dependency 'activesupport', '~> 3'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be '>= 3.0', '< 5.0'.

@yujinakayama
Copy link
Owner

OK, I've updated the dependency by myself. Thanks for the suggestion!

@jkingdon jkingdon deleted the allow-rails3 branch May 25, 2014 04:21
@jkingdon
Copy link
Author

Sounds good. Sorry for not getting around to updating the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants