-
Notifications
You must be signed in to change notification settings - Fork 404
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixed content causes a queued item to remain pending indefinitely #260
Labels
Comments
cameronbraid
changed the title
Mixed content causes a queued item to remain pending indefinately
Mixed content causes a queued item to remain pending indefinitely
Jun 2, 2018
@cameronbraid |
Find another bug with |
should be resolved with puppeteer update to v1.20.0 |
kulikalov
added a commit
that referenced
this issue
Oct 26, 2020
### Changed - Update [jquery](https://github.com/jquery/jquery) version to 3.5.1. - Update [lodash](https://lodash.com) version to 4.17.20. - Update [puppeteer](https://github.com/puppeteer/puppeteer) version to 1.20.0. - Update [request](https://github.com/request/request) version to 2.88.2. - Update [request-promise](https://github.com/request/request-promise) version to 4.2.6. - Update [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped) version to 4.14.162. - Update [@types/puppeteer](https://github.com/DefinitelyTyped/DefinitelyTyped) version to 1.20.0. - Update [@types/request-promise](https://github.com/DefinitelyTyped/DefinitelyTyped) version to 4.1.46. ### Fixed - Fix `crawler.response` returning `null` when connecting to specific chrome instance (Closes #354). - Fix crawler failure to follow urls with `#` hashes in them (Closes #332). - Fix crawler pending indefinitely when mixed content is present (Closes #260). ### Security - Fix: 🔒 high-severity lodash vulnerability (Closes #339). - Fix: 🔒 update jquery and lodash to fix Prototype Pollution vulnerability. - Fix: 🔒 update puppeteer to fix Use After Free vulnerability (Closes #350). - Fix: 🔒 update JQuery to fix XSS vulnerability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the current behavior?
When a HTTPS url is crawled that contains mixed content (e.g. http iframe tag) the crawler never calls onSuccess callback or emits requestfinished or onError callback or emits requestfailed and pendingQueueSize never returns to 0
If the current behavior is a bug, please provide the steps to reproduce
Crawl a HTTPS page that includes a http image or iframe tag
What is the expected behavior?
Good question... I would expect that the onError callback and requestfailed event is emitted
What is the motivation / use case for changing the behavior?
The crawl never ends and there is no notiifcation as to why
Please tell us about your environment:
The text was updated successfully, but these errors were encountered: