Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support split certificate/key p12 files #7

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

edodusi
Copy link
Contributor

@edodusi edodusi commented Aug 5, 2020

We needed to have two different files for p12 key and certificate. This PR adds the possibility to either pass the single file parameter or the two files, as reported in the updated README.

Copy link
Owner

@yukiarrr yukiarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edodusi Thanks for your contribution! One request.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Edoardo Dusi <edoardo.dusi@gmail.com>
Co-authored-by: Paolo Mainardi <paolo.mainardi@sparkfabrik.com>
Copy link
Owner

@yukiarrr yukiarrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yukiarrr yukiarrr merged commit 99b2b85 into yukiarrr:master Aug 8, 2020
@yukiarrr
Copy link
Owner

yukiarrr commented Aug 8, 2020

@edodusi Including this PR, v1.1.0 has been released.

rbravo21 pushed a commit to rbravo21/ios-build-action that referenced this pull request Aug 19, 2022
Support split certificate/key p12 files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants