Feature ckeditor #253
Merged
Feature ckeditor #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amenk
added a commit
to iMi-digital/redmine_mentions
that referenced
this pull request
May 26, 2016
- Contains textcomplete from my pull request yuku/textcomplete#253 - Basically compatible with the tabs plugin and other quirks - Also deactivate the overlay which destroys the CK Editor
amenk
added a commit
to iMi-digital/redmine_mentions
that referenced
this pull request
May 26, 2016
- Contains textcomplete from my pull request yuku/textcomplete#253 - Basically compatible with the tabs plugin and other quirks - Also deactivate the overlay which destroys the CK Editor
|
I've merged #252. Can you rebase to the current master? |
|
With or without dist?
|
|
without dist :) |
- Instance currently hardcoded - Known issue: Space after complete not included
Problem was, that spaces after the completion were "Eaten" by CKEditor. Don't worry, the is replaced by a normal space on the next non-space anyways. Search was delayed as well, i.e. the last key was not used in the search, that is why we listen again to the native event.
|
Rebasing is fun! :-) Here you go. |
|
I did frontend tests on IE10, 11, FF 46, Chrome 50, Opera 37 with EasyRedmine (CKEditor with the Tabs plugin on - that inserts spaces on the press of the tab key) |
Thanks 👍 |
yuku
added
the
DEPRECATED jquery-textcomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/yuku-t/textcomplete/issues/35 and so on