Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with CKEditor / TinyMCE #285

Closed
namaljayathunga opened this issue Sep 3, 2016 · 8 comments
Closed

Integration with CKEditor / TinyMCE #285

namaljayathunga opened this issue Sep 3, 2016 · 8 comments
Labels
DEPRECATED jquery-textcomplete Issues associated to jquery-textcomplete (was DEPRECATED) question

Comments

@namaljayathunga
Copy link

namaljayathunga commented Sep 3, 2016

I tried to integrate jquery-textcomplete with ckeditor, then I got this error.
TypeError: CKEDITOR.instances.issue_notes is undefined
Can you guise give me a little help to accomplish this. I will put the code sample bellow. You can quickly look at this. Thanks.

This is jsfiddle : https://jsfiddle.net/btjapqkp/

@yuku yuku added the question label Sep 4, 2016
@namaljayathunga namaljayathunga changed the title Integration with CKEditor Integration with CKEditor / TinyMCE Sep 15, 2016
@amenk
Copy link
Contributor

amenk commented Sep 15, 2016

Oh my...

When I made the patch, I was integrating it into Redmine (EasyRedmine). Looks like Redmine specific code sneaked into the jquery-textcomplete - this is of course wrong. In this line, it should be the CKEDITOR instance.
I can not dig deeper into it at this moment, but maybe that helps you to make a fix?

@namaljayathunga
Copy link
Author

Thanks @amenk, It is will be understandable for me if you can edit jsfiddle. Thanks.

@amenk
Copy link
Contributor

amenk commented Sep 17, 2016

I would have to look deeper in it - it is a bug in the textcomplete package - "proudly" introduced by me :'-(

amenk added a commit to iMi-digital/jquery-textcomplete that referenced this issue Sep 17, 2016
Some Redmine specific code slipped in which is now removed.
The CKEditor is stored in an option to be available in the ckeditor plugin.
@amenk
Copy link
Contributor

amenk commented Sep 17, 2016

@namaljayathunga Please check my patch

@namaljayathunga
Copy link
Author

namaljayathunga commented Sep 18, 2016

wow It's working 👍. Thanks @amenk for your quick contributing. However, there is an error when selected text replaced. check this jsfiddle. I'm using latest jquery-textcomplete.

@amenk
Copy link
Contributor

amenk commented Sep 18, 2016

Did you rebuild jquery-textcomplete? In my pull request I changed only the src/ folder - not dist/.
Additionally in the fiddle I think you should call textcomplete on the CKEditor textarea first before intialize the CKeditor.

@amenk
Copy link
Contributor

amenk commented Sep 18, 2016

Okay .. It is working, as long as there are not so much other edits on the page:
https://jsfiddle.net/btjapqkp/8/
Further PRs are appreciated :)

@namaljayathunga
Copy link
Author

Thanks a lot @amenk for dedicate your value time. using ID as a selector, I could use more editor.

yuku pushed a commit that referenced this issue Sep 20, 2016
Fix #285: Remove dependency on Redmine / issue_notes undefined
@yuku yuku added the DEPRECATED jquery-textcomplete Issues associated to jquery-textcomplete (was DEPRECATED) label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEPRECATED jquery-textcomplete Issues associated to jquery-textcomplete (was DEPRECATED) question
Projects
None yet
Development

No branches or pull requests

3 participants