Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/responsibility refactor #4

Merged
merged 16 commits into from
Dec 14, 2021
Merged

Conversation

el-hoshino
Copy link
Member

A big fix of responsibility refactor:

  • Rename CheckResult to Report
  • Make Report a pure data structure type
  • Add a MarkdownConfiguration type for formatting customization
  • Move formatting implementations to Shoki
  • Tests and README updates due to modifications above

@el-hoshino el-hoshino requested a review from a team December 2, 2021 18:17
@el-hoshino el-hoshino self-assigned this Dec 2, 2021
Copy link
Member

@daichikuwa0618 daichikuwa0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@novr novr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@el-hoshino el-hoshino merged commit e0941e5 into main Dec 14, 2021
@el-hoshino el-hoshino deleted the feature/ResponsibilityRefactor branch December 14, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants