Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/responsibility refactor #4

Merged
merged 16 commits into from
Dec 14, 2021
Merged

Feature/responsibility refactor #4

merged 16 commits into from
Dec 14, 2021

Commits on Dec 2, 2021

  1. Remove all markdown formatting implementations from CheckResult to ma… 

    …ke it a simple data structure to just store check results and todos
    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    ba4ef27 View commit details
    Browse the repository at this point in the history

  2. Add a public MarkdownConfiguration type to specify required markdown … 

    …formatting implementations
    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    06ed859 View commit details
    Browse the repository at this point in the history

  3. Using the new MarkdownConfiguration from Shoki

    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    2408cca View commit details
    Browse the repository at this point in the history

  4. Update shoki property from DangerDSL

    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    c5307d7 View commit details
    Browse the repository at this point in the history

  5. Move checking methods from CheckResult to Shoki to make CheckResult m… 

    …ore simple and pure
    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    805b0a3 View commit details
    Browse the repository at this point in the history

  6. Update tests for CheckResult and Shoki

    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    cab73e5 View commit details
    Browse the repository at this point in the history

  7. Add tests for MarkdownConfiguration

    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    92a4d8d View commit details
    Browse the repository at this point in the history

  8. Rename CheckResult to Report

    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    25ed6ca View commit details
    Browse the repository at this point in the history

  9. Fix tests

    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    eaf9ea7 View commit details
    Browse the repository at this point in the history

  10. Update README

    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    aaed166 View commit details
    Browse the repository at this point in the history

  11. Make Report Equatable so it's easier to make tests to compare reports

    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    928f28f View commit details
    Browse the repository at this point in the history

  12. Update MarkdownConfiguration and Shoki according to Report update

    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    2cd7c0b View commit details
    Browse the repository at this point in the history

  13. Update Report tests

    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    7e59149 View commit details
    Browse the repository at this point in the history

  14. Update ShokiTests

    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    6e7a216 View commit details
    Browse the repository at this point in the history

  15. Minor fix for MarkdownConfigurationTests

    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    f85dd51 View commit details
    Browse the repository at this point in the history

  16. Add missing .lazy in failures in Report

    @el-hoshino
    el-hoshino committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    b8bcc9e View commit details
    Browse the repository at this point in the history