dart fix --dry-run での確認フローを追加 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trm11tkr
commented
Feb 4, 2024
|
|
||
| PIDS=() | ||
| for file in "${files[@]}"; do | ||
| # limit jobs to 5 |
There was a problem hiding this comment.
|
|
||
| ( | ||
| # Note: The script relies on the 'Nothing to fix!' output from 'dart fix --dry-run'. | ||
| # This dependency might be an issue if the output format changes in future Dart versions. |
There was a problem hiding this comment.
dart fix --dry-run の出力の最後が 「Nothing to fix!」で終了しているかで判定
背景
dart fix --applyを実行し、git diff による差分で比較しない理由
実行速度において、dart fix --dry-run は dart fix --applyより遥かに速いため
「Nothing to fix!」という文言で判定している理由
dart fix --dry-runは修正必要なファイルを検出してもステータスコード 0 を返すため
FYI: dart fix --dry-run の実行結果
修正必要なファイルなし
fvm dart fix --dry-run
Computing fixes in flutter-mobile-project-template (dry run)...
Nothing to fix!
修正必要なファイルを検出
fvm dart fix --dry-run
Computing fixes in flutter-mobile-project-template (dry run)...
1 proposed fix in 1 file.
apps/app/lib/main.dart
directives_ordering - 1 fix
To fix an individual diagnostic, run one of:
dart fix --apply --code=directives_ordering
To fix all diagnostics, run:
dart fix --apply
| # Note: The script relies on the 'Nothing to fix!' output from 'dart fix --dry-run'. | ||
| # This dependency might be an issue if the output format changes in future Dart versions. | ||
| if ! dart fix --dry-run "$file" | grep -q "Nothing to fix!"; then | ||
| echo "Fixes might be needed for $file" |
There was a problem hiding this comment.
dart fix --dry-runの実行ログが表示されないようになるため、修正必要ファイルが検出された際にはメッセージを表示
trm11tkr
changed the title
|
Ready for review 🚀 |
|
@Kotaro666-dev @warahiko |
warahiko
reviewed
Feb 7, 2024
scripts/check-format-ci.sh
Outdated
Comment on lines
13
to
15
| find_files() { | ||
| find . -name "*.dart" -not \( -name "*.freezed.dart" -o -name "*.g.dart" -o -name "*.gen.dart" -o -path "*/gen/*.dart" -o -path "./.dart_tool/*" \) -print0 | ||
| } |
There was a problem hiding this comment.
このあたり format.sh でもありますし、管理上漏れが出そうな見た目してるので共通化したほうがいいかもしれないですね
There was a problem hiding this comment.
common.sh というのが一般的すぎる気もしますが、今のところ問題ないかなと思いました 👍
（ $0 より適当な書き方があるんですね......！勉強なります）
|
@warahiko @Kotaro666-dev |
warahiko
approved these changes
Feb 13, 2024
…w_of_dart_fix_on_ci
|
レビューしていただきありがとうございました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
close #72
レビュー観点
レビューレベル
レビュー優先度
画像 / 動画
動作変更なし
動作確認手順
動作変更なし
備考
参考
https://gist.github.com/hell0again/f5f3064ad1ea6c5c7308