Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart fix --dry-run での確認フローを追加 #113
dart fix --dry-run での確認フローを追加 #113
Changes from 3 commits
5fbe518
85076d8
86c2993
ab2dc3b
4c024f6
ad5cfc8
51d849b
f8c874c
c49fb7a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
このあたり format.sh でもありますし、管理上漏れが出そうな見た目してるので共通化したほうがいいかもしれないですね
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4c024f6にて共通化しました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
common.sh というのが一般的すぎる気もしますが、今のところ問題ないかなと思いました 👍
( $0 より適当な書き方があるんですね......!勉強なります)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ジョブの実行を5に制限する
FYI:
https://github.com/FlutterKaigi/2023/blob/5add6883ca94e1257a296e47befd6aded2338489/.github/workflows/auto-format.yaml#L29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dart fix --dry-run
の出力の最後が 「Nothing to fix!」で終了しているかで判定背景
dart fix --apply
を実行し、git diff
による差分で比較しない理由実行速度において、
dart fix --dry-run
はdart fix --apply
より遥かに速いため「Nothing to fix!」という文言で判定している理由
dart fix --dry-run
は修正必要なファイルを検出してもステータスコード 0 を返すためFYI:
dart fix --dry-run
の実行結果修正必要なファイルなし
修正必要なファイルを検出
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dart fix --dry-run
の実行ログが表示されないようになるため、修正必要ファイルが検出された際にはメッセージを表示