Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #45

Merged
merged 1 commit into from Jun 6, 2023
Merged

Update README.md #45

merged 1 commit into from Jun 6, 2023

Conversation

el-hoshino
Copy link
Member

リポジトリの作成オーガナイゼーションを修正

リポジトリの作成オーガナイゼーションを修正
@el-hoshino el-hoshino requested a review from a team June 5, 2023 19:17
@el-hoshino el-hoshino self-assigned this Jun 5, 2023
Copy link
Member

@ykws ykws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@daichikuwa0618 daichikuwa0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正内容的には違和感ありません。ありがとうございます 🙇

@@ -17,7 +17,7 @@ SwiftPackageManagerに対応しています。

## 研修の進め方
1. 空白の研修用のリポジトリを作成
1. organizationでレビュアーユーザグループを設定してある場合、該当organizationでリポジトリを作成するとレビュアー設定しやすいです。ゆめみの場合は [yumemi](https://github.com/yumemi) で作成します。
1. organizationでレビュアーユーザグループを設定してある場合、該当organizationでリポジトリを作成するとレビュアー設定しやすいです。ゆめみの場合は [yumemi-inc](https://github.com/yumemi-inc) で作成します。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public or private のどっちで作るのか迷ったので、書いてあっても良さそうに思いました。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daichikuwa0618 それまた別途検討しましょうか 🤔

@el-hoshino
Copy link
Member Author

マージしますー

@el-hoshino el-hoshino merged commit 372f9df into main Jun 6, 2023
@el-hoshino el-hoshino deleted the readme-org-fix branch June 6, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants