Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry limiter #160

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Add retry limiter #160

merged 1 commit into from
Nov 9, 2019

Conversation

wnxn
Copy link
Contributor

@wnxn wnxn commented Nov 9, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #159

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add retry limiter in ControllerUnpublishVolume

Additional documentation e.g., usage docs, etc.:


@ks-ci-bot ks-ci-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 9, 2019
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wnxn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2019
@wnxn wnxn added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2019
@ks-ci-bot ks-ci-bot merged commit e112008 into yunify:master Nov 9, 2019
@wnxn wnxn deleted the limit-detach branch November 11, 2019 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit retry times when volume detach failed
2 participants