Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get ride of /var/log/$app stuff #107

Closed
yalh76 opened this issue Apr 19, 2020 · 5 comments · Fixed by #110
Closed

get ride of /var/log/$app stuff #107

yalh76 opened this issue Apr 19, 2020 · 5 comments · Fixed by #110
Labels
enhancement New feature or request

Comments

@yalh76
Copy link
Member

yalh76 commented Apr 19, 2020

There are several places in the package that refer to /var/log/$app but I'm not sure if pixelfed_ynh can log something...

If it can log thing we should check that it logs them... If not, references to that should be removed

@yalh76 yalh76 added the enhancement New feature or request label Apr 19, 2020
@lapineige
Copy link
Member

I have no /var/log/$app on my server.
Logging could be used for fail2ban at least, but I don't know if pixelfed log anything or not.

@yalh76
Copy link
Member Author

yalh76 commented Apr 22, 2020

I v'e added creation of the log file in

mkdir -p "/var/log/$app/"
touch "/var/log/$app/${app}-horizon.log"
chown -R root: "/var/log/$app/"
:) so we will keep /var/logs

@yalh76 yalh76 mentioned this issue Apr 22, 2020
5 tasks
@lapineige
Copy link
Member

lapineige commented Apr 23, 2020

Let's see if it logs failed connection attempts, and if that case we could setup a fail2ban rule. #22

@yalh76
Copy link
Member Author

yalh76 commented Apr 23, 2020

I'm really not sure that connection attempts are logged. If you have time to do some test on a test pixelfed_ynh on the branch https://github.com/YunoHost-Apps/pixelfed_ynh/tree/from_documentation let me know...

@lapineige
Copy link
Member

Well, if someone else doesn't do it before me, I'm surely going to try… but I don't have time yet.

@yalh76 yalh76 mentioned this issue Apr 26, 2020
5 tasks
@yalh76 yalh76 linked a pull request May 26, 2020 that will close this issue
5 tasks
@yalh76 yalh76 closed this as completed May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants