Merge pull request sidekiq#2352 from TeachstoneLLC/ms/better_configur…

…ation_file_parameter_validation

Validate parameters in config file

lib/sidekiq/cli.rb

@@ -269,6 +269,25 @@ def validate!
         logger.info @parser
         die(1)
       end
+
+      # Ensure numeric option values are numbers and fall in reasonable ranges
+      [:concurrency, :timeout].each do |option|
+        next unless options.has_key?(option)
+
+        unless options[option].is_a? Integer
+          raise(
+            ArgumentError,
+            %{"#{option}": "#{options[option]}" is not a valid integer}
+          )
+        end
+
+        if options[option] <= 0
+          raise(
+            ArgumentError,
+            %{"#{option}": must be > 0 (current value: #{options[option]})}
+          )
+        end
+      end
     end
 
     def parse_options(argv)