Skip to content

Commit

Permalink
docs(csharp): refer to net8.0 (new LTS) (microsoft#28664)
Browse files Browse the repository at this point in the history
  • Loading branch information
mxschmitt committed Dec 15, 2023
1 parent 44c3ad5 commit dfd8f25
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 14 deletions.
10 changes: 5 additions & 5 deletions docs/src/ci-intro.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,10 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@v3
with:
dotnet-version: 6.0.x
dotnet-version: 8.0.x
- run: dotnet build
- name: Ensure browsers are installed
run: pwsh bin/Debug/net6.0/playwright.ps1 install --with-deps
run: pwsh bin/Debug/net8.0/playwright.ps1 install --with-deps
- name: Run your tests
run: dotnet test
```
Expand Down Expand Up @@ -268,7 +268,7 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@v3
with:
dotnet-version: 6.0.x
dotnet-version: 8.0.x
- run: dotnet build
- name: Run your tests
run: dotnet test
Expand Down Expand Up @@ -372,10 +372,10 @@ jobs:
- name: Setup dotnet
uses: actions/setup-dotnet@v3
with:
dotnet-version: 6.0.x
dotnet-version: 8.0.x
- run: dotnet build
- name: Ensure browsers are installed
run: pwsh bin/Debug/net6.0/playwright.ps1 install --with-deps
run: pwsh bin/Debug/net8.0/playwright.ps1 install --with-deps
- name: Run tests
run: dotnet test
env:
Expand Down
6 changes: 3 additions & 3 deletions docs/src/ci.md
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,11 @@ steps:
- task: UseDotNet@2
inputs:
packageType: sdk
version: '6.0.x'
version: '8.0.x'
displayName: 'Use .NET SDK'
- script: dotnet build --configuration Release
displayName: 'Build'
- script: pwsh bin/Release/net6.0/playwright.ps1 install --with-deps
- script: pwsh bin/Release/net8.0/playwright.ps1 install --with-deps
displayName: 'Install Playwright browsers'
- script: dotnet test --configuration Release
displayName: 'Run tests'
Expand Down Expand Up @@ -367,7 +367,7 @@ steps:
- task: UseDotNet@2
inputs:
packageType: sdk
version: '6.0.x'
version: '8.0.x'
displayName: 'Use .NET SDK'
- script: dotnet build --configuration Release
Expand Down
2 changes: 1 addition & 1 deletion docs/src/intro-csharp.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ dotnet add package Microsoft.Playwright.MSTest
dotnet build
```

4. Install required browsers by replacing `netX` with the actual output folder name, e.g. `net6.0`:
4. Install required browsers by replacing `netX` with the actual output folder name, e.g. `net8.0`:

```bash
pwsh bin/Debug/netX/playwright.ps1 install
Expand Down
2 changes: 1 addition & 1 deletion docs/src/library-csharp.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ cd PlaywrightDemo
dotnet add package Microsoft.Playwright
# Build the project
dotnet build
# Install required browsers - replace netX with actual output folder name, e.g. net6.0.
# Install required browsers - replace netX with actual output folder name, e.g. net8.0.
pwsh bin/Debug/netX/playwright.ps1 install

# If the pwsh command does not work (throws TypeNotFound), make sure to use an up-to-date version of PowerShell.
Expand Down
8 changes: 4 additions & 4 deletions docs/src/webview2.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ import childProcess from 'child_process';

const EXECUTABLE_PATH = path.join(
__dirname,
'../../webview2-app/bin/Debug/net6.0-windows/webview2.exe',
'../../webview2-app/bin/Debug/net8.0-windows/webview2.exe',
);

export const test = base.extend({
Expand Down Expand Up @@ -148,7 +148,7 @@ public class WebView2Process {
public int cdpPort;
private Path _dataDir;
private Process _process;
private Path _executablePath = Path.of("../webview2-app/bin/Debug/net6.0-windows/webview2.exe");
private Path _executablePath = Path.of("../webview2-app/bin/Debug/net8.0-windows/webview2.exe");

public WebView2Process() throws IOException {
cdpPort = nextFreePort();
Expand Down Expand Up @@ -268,7 +268,7 @@ EXECUTABLE_PATH = (
/ "webview2-app"
/ "bin"
/ "Debug"
/ "net6.0-windows"
/ "net8.0-windows"
/ "webview2.exe"
)

Expand Down Expand Up @@ -361,7 +361,7 @@ public class WebView2Test : PlaywrightTest
public IPage Page { get; internal set; } = null!;
private Process? _webView2Process = null;
private string _userDataDir = null!;
private string _executablePath = Path.Join(Directory.GetCurrentDirectory(), @"..\..\..\..\webview2-app\bin\Debug\net6.0-windows\webview2.exe");
private string _executablePath = Path.Join(Directory.GetCurrentDirectory(), @"..\..\..\..\webview2-app\bin\Debug\net8.0-windows\webview2.exe");

[SetUp]
public async Task BrowserSetUp()
Expand Down

0 comments on commit dfd8f25

Please sign in to comment.