L2ACIP-335: fix Magento version parsing regex #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New flags for --live-search and --prex
Fixed: Some of Live Search modules were not enabled during the installation.
…-remove-dumps Add option to not delete dumps
if force: no prompt but keep files if force and delete-dumps no prompt and delete all
Allow to delete dump directory but keep dumps, ex: php*.code.tar.gz
…-to-delete-dumps Sparta 351/separate options to delete dumps
Merging changes from the upstream (Apr 14)
…to_TwoFactorAuth module
Fix: Magento_AdminAdobeImsTwoFactorAuth module blocks disabling Magento_TwoFactorAuth module
This reverts commit 75cd480.
…te-project error handling
* Add opensearch to getRecommendedSearchEngineForVersion() * Add opensearch in parseElasticSearchVersion() * Add opensearch into getESConfigHost() and getESConfigPort() * Add opensearch into installMagento()
SPARTA-521/SPARTA-533/SPARTA-537: add opensearch, error management and validations
Fixed empty password and not removing dump files
Sometimes having session size 0 causes troubles and doesn't allow to login into admin backend. Details: ACSD-61470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the regexp used for parsing Magento version. It fixes how dev versions like
Magento CLI dev-2.4-developget parsed.Details: https://jira.corp.adobe.com/browse/L2ACIP-335