Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voting should submit just the item that changed #30

Open
ywwg opened this issue Nov 23, 2016 · 1 comment
Open

voting should submit just the item that changed #30

ywwg opened this issue Nov 23, 2016 · 1 comment

Comments

@ywwg
Copy link
Owner

ywwg commented Nov 23, 2016

this has bugged me forever. The form currently submits the entire form on every change. Instead, the submit function should take the form element name as an argument. The submit function can then read the form and build the post data with a single item. Then the vote function can load the correct proposal, set the single value, and save.

@ywwg
Copy link
Owner Author

ywwg commented Dec 11, 2016

There is a partial fix to this already -- we pass all of the votes over the POST command, but we only save votes that we detect are different from the database. So at least from a hit-the-db perspective, this is better.

ywwg pushed a commit that referenced this issue Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant