Skip to content

Commit

Permalink
a potential solution to Chia-Network#14874
Browse files Browse the repository at this point in the history
I opted to change the short option for `--request` to `-R` and for consistency give `-O` as the short option for `--offer`

- `-r, --reuse` is option for more than one command, so I thought it would make more sense to give lowercase `-r` to `reuse` so I opted to go with `-R` for the short option 
- `-o` is also used as the short option for `--offset` and `--override`, although it doesn't have any conflicts for `make_offer` it made sense to change it to be consistent with the short option that is often used in tandem

https://github.com/Chia-Network/chia-docs/blob/main/docs/guides/tutorials/offers-cli.md should be updated if this is merged
  • Loading branch information
yyolk committed May 3, 2023
1 parent 8b8f77a commit b1917e9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions chia/cmds/wallet.py
Original file line number Diff line number Diff line change
Expand Up @@ -402,14 +402,14 @@ def add_token_cmd(wallet_rpc_port: Optional[int], asset_id: str, token_name: str
)
@click.option("-f", "--fingerprint", help="Set the fingerprint to specify which key to use", type=int)
@click.option(
"-o",
"-O",
"--offer",
help="A wallet id to offer and the amount to offer (formatted like wallet_id:amount)",
required=True,
multiple=True,
)
@click.option(
"-r",
"-R",
"--request",
help="A wallet id of an asset to receive and the amount you wish to receive (formatted like wallet_id:amount)",
required=True,
Expand Down

0 comments on commit b1917e9

Please sign in to comment.