Improve lsp--try-open-in-library-workspace handling #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix some poor naming - use `lsp--support-buffer?` in `lsp--try-open-in-library-workspace`
yyoncho
pushed a commit
that referenced
this pull request
Nov 15, 2023
* Advoid delete user directory, prevent install dependency twice * Remove kill installed dep * Add test packages * Update year * Add comment instead of deleting it * Add comment * Add test for emacs-lsp packages * Module makefile * Add test entry * Install lsp-mode itself * Install itself after initialization * Add expand * Remove print * Print out version * Add test * Should be pkg alist * Add test def * Add req * Revert test * Test for all emacs-lsp packages * Fix year * Test attempt #1 * Ensure win bootstrap * Cut test 1 * Cut test 2 * Cut test emacs-lsp#3 * Cut test emacs-lsp#4 * Cut test emacs-lsp#5 * Add note about lsp-dart * Remove verbose comment * Revert newline * Clean up using env * Test lsp-dart * Set on warn when installing lsp packages * Use specify process with downstream * Compare list instead of lsp string * Make sure is either t or nil * Add more downstream packages to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsp--support-buffer?inlsp--try-open-in-library-workspace