CI test for emacs-lsp packages

[jcs090218]

This if for #2655

[jcs090218]

@jcs090218 I couldn't find anything related to lsp-dart, but we do have a Notification protocol not used here 🤔,

Yeah, this looks strange to me. But I sometime do get this warning. See if I can reproduce this. 😕

[yyoncho]

Error is here, https://github.com/emacs-lsp/lsp-mode/runs/2046252831.

The issue is that we have 2 lsp-make-notification functions, one in lsp-mode.el and one in lsp-protocol.el, we should remove the one in lsp-mode.el

[jcs090218]

The issue is that we have 2 lsp-make-notification functions, one in lsp-mode.el and one in lsp-protocol.el, we should remove the one in lsp-mode.el

I could not find the second lsp-make-notification in lsp-protocol.el. Is the line generates it's function?

lsp-mode/lsp-protocol.el

Line 110 in 800591f

`(cl-defun ,(intern (format "lsp-make-%s" (s-dashed-words (symbol-name interface))))

I think I should delete the one in lsp-mode?

[ericdallo]

@jcs090218 I think @yyoncho meant https://github.com/emacs-lsp/lsp-dart/blob/master/lsp-dart-protocol.el#L57

I think we can rename the function on lsp-mode or rename on dart side, I don't mean to remove that on Dart side as is not being used ATM, I just added to follow the spec

[yyoncho]

@jcs090218 I think @yyoncho meant https://github.com/emacs-lsp/lsp-dart/blob/master/lsp-dart-protocol.el#L57

I think we can rename the function on lsp-mode or rename on dart side, I don't mean to remove that on Dart side as is not being used ATM, I just added to follow the spec

Lets remove the dart side.

[yyoncho]

But generally, we should prefix the non-core interfaces.

[ericdallo]

I'll remove it and later add the prefix, it makes sense @yyoncho

[ericdallo]

Done on master @jcs090218, it should be available on MELPA in 1hour

[jcs090218]

All checks have passed! 🎉 Let me know if I still need to change anything! ;)

[ericdallo]

LGTM, thank you for that @jcs090218 :)

[yyoncho]

Looks good to me! I think this is a great addition to our infrastructure. Now it will be much easier to perform cleanup.

[jcs090218]

All checks have passed (again)! Let me merge this for now before this PR get larger and larger. I would apply another patch if needed! :)

Thanks for anyone who reviewed this PR. 🎉