Fix improper implementation of DiffMargin.Dispose

yysun · Mar 19, 2013 · 04edbd0 · 04edbd0
1 parent d2440fb
commit 04edbd0
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Diff/DiffMargin.cs b/Diff/DiffMargin.cs
@@ -11,7 +11,7 @@
     using Microsoft.VisualStudio.Text.Editor;
     using Microsoft.VisualStudio.Text.Editor.OptionsExtensionMethods;
 
-    public class DiffMargin : IWpfTextViewMargin
+    public sealed class DiffMargin : IWpfTextViewMargin
     {
         public const string MarginName = "GitDiffMargin";
 
@@ -136,12 +136,12 @@ public ITextViewMargin GetTextViewMargin(string marginName)
 
         public void Dispose()
         {
-            GC.SuppressFinalize(this);
             _viewModel.Cleanup();
             _isDisposed = true;
+            GC.SuppressFinalize(this);
         }
 
-        protected virtual void OnBrushesChanged(EventArgs e)
+        private void OnBrushesChanged(EventArgs e)
         {
             var t = BrushesChanged;
             if (t != null)