-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not assume selected theme is in a cache dir #24
Conversation
When ~/.cache is a tmpfs, the selected theme is lost on reboot. This commit ensures that the selected theme is searched in the $FAST_WORK_DIR when it is set instead of assuming it is in a cache directory.
It seems it's still not perfect though, as when starting a new shell it still writes somehow a secondary theme:
Not sure where that one comes from 👀 |
Ok it seems I didn't solve it at all: (I probably should have created a proper issue first) I have: FAST_WORK_DIR=~/.long_term_cache/zsh--fast-syntax-highlighting
echo "FAST_WORK_DIR (before zi): $FAST_WORK_DIR"
zi light z-shell/F-Sy-H
echo "FAST_WORK_DIR (after zi): $FAST_WORK_DIR" And when starting zsh I get:
|
Hi @bew 👋 Could you describe your environment e.g: echo "OSTYPE=${OSTYPE} CPUTYPE=$(uname -m) MACHINE_TYPE=$MACHTYPE ZSH_VERSION=${ZSH_VERSION}" Or any other additional information which would help to reproduce the issue, this data also gets collected to improve tests. I keep forgetting to update issue templates |
Sure, I created a separate issue, I've put the requested env in it: #25 |
gitstatus' bootstrap was auto-downloading its pre-compiled binary to a directory in ~/.cache, which is a tmpfs => empty on boot. Similarly fast-syntax-highlighting was saving which theme is selected in a directory in ~/.cache => empty on boot, so it was falling back on default theme. (also update this plugin, and point it to an updated fork)
I'm not sure what you want me to do for my tentative PR, I'll just close that PR (it's so small anyway) and let you do the changes. |
When ~/.cache is a tmpfs, the selected theme is lost on reboot.
This commit ensures that the selected theme is searched in $FAST_WORK_DIR
when it is set instead of assuming it is in a cache directory.