Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

新修复的export [#2491 #2426]，又有新问题，导出文件头部出现<div class="row"><div class="col-md-12"> #2529

Closed
tomcoolz opened this issue Sep 20, 2018 · 1 comment
Closed

新修复的export [#2491 #2426]，又有新问题，导出文件头部出现<div class="row"><div class="col-md-12"> #2529

tomcoolz opened this issue Sep 20, 2018 · 1 comment

Comments

@tomcoolz
Copy link

tomcoolz commented Sep 20, 2018 •
edited
Loading

  • Laravel Version: 5.6.34
  • PHP Version: 7.2.4
  • Laravel-admin: 1.6.1

Description:

Fix issue #2491 #2426，但导出的文件头部出现<div class="row"><div class="col-md-12">

Steps To Reproduce:

翻了下源码，Encore\Admin\Grid::handleExportRequest() 被执行了2次，应该是第1次时没执行export()输出，然后触发了 Encore\Admin\Layout\Row 和 Encore\Admin\Layout\Column 的 build()。
望优化流程。
z-song added a commit that referenced this issue Sep 20, 2018
@z-song
[fix]Fix issue #2529
5d6aa67
@z-song
Copy link
Owner

z-song commented Sep 20, 2018

@tomcoolz 确实有这个问题，提交了修复，更新到v1.6.3

@z-song z-song closed this as completed Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@z-song @tomcoolz