This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Prev. Comments & Formatting #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z0al
suggested changes
Apr 9, 2018
lib/comments.js
Outdated
| let result | ||
| //iterates over all the comments | ||
| for (comment of comments['data']){ | ||
| if(comment.user.login=='commitlint[bot]'&&comment.user.type=='Bot'){ //looks for the first comment made by the bot |
There was a problem hiding this comment.
I'm not sure about this but it has to better a better way to check for bot's comment other that it's login name.
This won't work for self-deployed instance since app names are unique.
There was a problem hiding this comment.
@ahmed-taj What do you think about https://developer.github.com/v3/apps/#get-the-authenticated-github-app & http://octokit.github.io/rest.js/#api-Apps-get?
|
Hey @newnewb thank you so much for this 👌 I took a quick review and it looks good. I've and commented on some parts, though. Also, please add some tests that cover your changes. Don't hesitate to ask for help here if you feel stuck. Thanks again for contributing 🌟 |
Repository owner
deleted a comment
Apr 9, 2018
Repository owner
deleted a comment
Apr 18, 2018
z0al
approved these changes
May 10, 2018
This was referenced Jul 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comment lookup
Fixed the indentation and formatting issue caused by the mapping