Event funcs #40

zabawaba99 · 2016-04-18T17:06:15Z

closes #36

zabawaba99 · 2016-04-18T17:06:50Z

event_callback.go

+	return fb.addEventFunc(fn, handleSSE)
+}
+
+func (fb *Firebase) ChildRemoved(fn ChildEventFunc) error {


Add documentation

the consumers of this function could use strings.Trim instead

using those constants for comparison in event callbacks and watch functions

…e for every callback

It was not sending an event per child if multiple children were added at once.

As a side-effect, also changing the implementation of a Datasnap shot and removing the dependency from sync.Node

Tonkpils · 2016-09-05T00:03:25Z

event_callback.go

+		}
+
+		// we have a single event to process
+		node := sync.NewNode(child, event.Data)


What do you think about L72-76 and L40-43 being extracted into a function that handles this?

zabawaba99 self-assigned this Apr 18, 2016

zabawaba99 reviewed Apr 18, 2016
View reviewed changes

zabawaba99 force-pushed the event-funcs branch 3 times, most recently from 9739164 to 56cd247 Compare April 20, 2016 02:32

zabawaba99 force-pushed the event-funcs branch from 6ba3217 to 480e9ac Compare May 2, 2016 00:22

zabawaba99 force-pushed the event-funcs branch from c5dd780 to 4a06973 Compare September 4, 2016 22:50

zabawaba99 added 16 commits September 4, 2016 19:00

adding initial implementation of ChildAdded

2ad9952

fixing gofmt

e39e004

adding tests for child added function

a3fc85c

adding a mtx for even callbacks and documentation

fb56df2

adding child removed handler

7c87118

removing some duplicate logic

567ea23

adding Key() to datasnapshot

210764d

changing snapshot.Child() to take a path instead of just a name

c78307f

moving database object into sync package

9f19ae1

getting rid of sanitize path function

6e4b67a

the consumers of this function could use strings.Trim instead

adding EventType constants.

dc1bf87

using those constants for comparison in event callbacks and watch functions

creating actual functions for callbacks instead of using a new closur…

f660764

…e for every callback

coverage for all packages

ccaa545

fixing race condition in tests

79da9ff

should not have been added

8bb364e

adding snapshot tests

f04f234

zabawaba99 added 4 commits September 4, 2016 19:00

fixing childAdded callback logic.

3def706

It was not sending an event per child if multiple children were added at once.

Adding in ChildChanged.

ebea0f4

As a side-effect, also changing the implementation of a Datasnap shot and removing the dependency from sync.Node

adding firetest as an internal package instead of a different repo

291ec17

using 1.6 and 1.7 for ci

f68a970

zabawaba99 force-pushed the event-funcs branch from 5be4be5 to f68a970 Compare September 4, 2016 23:00

Tonkpils reviewed Sep 5, 2016
View reviewed changes

zabawaba99 added 6 commits September 4, 2016 20:47

scoping functions to childeventfunc type

d2b87b4

pk -> prevKey

1949303

pulling out similar sorting logic

30feb36

fixing golint complains

4aa0e6f

Adding in the function overriding warning

c3ee371

making the database object thread safe

fe748aa

zabawaba99 merged commit 8f771bb into master Sep 25, 2016

zabawaba99 deleted the event-funcs branch September 25, 2016 01:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Event funcs #40

Event funcs #40

zabawaba99 commented Apr 18, 2016 •

edited

Loading

zabawaba99 Apr 18, 2016 •

edited

Loading

Tonkpils Sep 5, 2016

zabawaba99 Sep 5, 2016

Event funcs #40

Event funcs #40

Conversation

zabawaba99 commented Apr 18, 2016 • edited Loading

zabawaba99 Apr 18, 2016 • edited Loading

Choose a reason for hiding this comment

Tonkpils Sep 5, 2016

Choose a reason for hiding this comment

zabawaba99 Sep 5, 2016

Choose a reason for hiding this comment

zabawaba99 commented Apr 18, 2016 •

edited

Loading

zabawaba99 Apr 18, 2016 •

edited

Loading