Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function Map.update/3 is undefined or private in Wit.Client.Deserializer #6

Closed
micahwedemeyer opened this issue Jan 5, 2017 · 3 comments

Comments

@micahwedemeyer
Copy link
Collaborator

On line 80 there's a call to Map.update/3. This gives me the error in the subject line.

Looking in the Elixir docs, there is a Map.update!/3 and a Map.update/4. It seems like this could be a typo, but maybe I'm missing something?

micahwedemeyer added a commit to micahwedemeyer/elixir_wit that referenced this issue Jan 5, 2017
micahwedemeyer added a commit to micahwedemeyer/elixir_wit that referenced this issue Jan 5, 2017
@micahwedemeyer
Copy link
Collaborator Author

Hmm, looks like it's a bit bigger than I thought. Perhaps the message function is based on an older response to the /message Wit call, because I don't see anything in their returned response about outcomes. Looking at one of the deprecated calls, I do see outcomes in there.

I didn't see anything on the blog about this specifically, but I'm assuming outcomes is deprecated. I guess I'll ask in the Facebook group.

micahwedemeyer added a commit to micahwedemeyer/elixir_wit that referenced this issue Jan 5, 2017
@zabirauf
Copy link
Owner

zabirauf commented Jan 8, 2017

If there is no outcomes in message anymore then we need to change the model as well to remove it in pull request #7

@micahwedemeyer
Copy link
Collaborator Author

Fixed in #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants