Fix Map.update bug in Deserializer #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahwedemeyer
force-pushed
the
fix-deserialize-bug
branch
from
4cff10c
to
7dbfff1
Compare
|
If the outcome is completely deprecated then we need to update the model accordingly as well and increase the major version number as its a contract change. |
|
I'll look into it, but my main concern is that a version change probably has repercussions across all the request endpoints: Perhaps as a step 1, we merge this PR, and step 2 is to branch and begin updating everything to the latest version. |
|
I'm going to close this request and open another one that represents a full update to the current Wit API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fixes #6]