Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Restart, Shutdown, and Reset State buttons to the multiAction bar #8

Merged
merged 8 commits into from
Dec 8, 2020
Merged

Conversation

eric-c-wood
Copy link

  1. Added Restart, Shutdown, and Reset State buttons to the multiAction bar
  2. Made several cosmetic UI changes. Added "cancel" buttons to diskImage and redeploy modal dialog boxes. Added "hr" tags when multiple VMs are selected. Added the ability to click on an IP address to start a packet capture.
  3. Changed the name of the variable "redeploying" to "busy" as it was being used in places where a VM was not redeploying. "Busy" seems to be more appropriate and makes the code easier to understand.
  4. Added in some placeholder buttons to the mutliAction toolbar to get an idea of screen real estate changes.

…oolbar. Made several cosmetic changes to the UI
@zach-r-long zach-r-long closed this Dec 3, 2020
@zach-r-long zach-r-long reopened this Dec 3, 2020
… name and pcap extension to pcap capture file. Updated UI colors for stopping captures
…e the captures array was getting set to null on page reloads. Minor UI cosmetic fixes
…ct total for the current number of displayed table items. Will need to look at the back end code to verify
…ll to GetVMInfo and made sure that the vm name was always passed to GetVMCaptures
@zach-r-long
Copy link
Owner

Looks really good! I like the modify state solution, very elegant!

One Issue.

image

I believe this should be the create backing image and have the old icon. Clicking it brings up the backing image creation UI.
image

Otherwise LOOKS GREAT

@eric-c-wood
Copy link
Author

eric-c-wood commented Dec 7, 2020 via email

@eric-c-wood
Copy link
Author

eric-c-wood commented Dec 8, 2020

Ok, I pushed a new set of updates. Also, I believe that I restored the old icon of "floppy-o" for the create backing image/create disk snapshot function. I added a default handler for the placeholder buttons "create memory snapshot and record screenshot". If the order of the buttons is not to your liking, we can always re-arrange. Currently, the buttons are ordered by function. For example, the buttons associated with snapshots are grouped together.

If you like the concept of button groups to conserve screen real estate, we can always add a button to represent a "snapshot" group. This of course assumes that we might add more buttons in the future.

@zach-r-long zach-r-long merged commit 44fc29b into zach-r-long:multiAction Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants