-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Restart, Shutdown, and Reset State buttons to the multiAction bar #8
Conversation
eric-c-wood
commented
Dec 3, 2020
- Added Restart, Shutdown, and Reset State buttons to the multiAction bar
- Made several cosmetic UI changes. Added "cancel" buttons to diskImage and redeploy modal dialog boxes. Added "hr" tags when multiple VMs are selected. Added the ability to click on an IP address to start a packet capture.
- Changed the name of the variable "redeploying" to "busy" as it was being used in places where a VM was not redeploying. "Busy" seems to be more appropriate and makes the code easier to understand.
- Added in some placeholder buttons to the mutliAction toolbar to get an idea of screen real estate changes.
…oolbar. Made several cosmetic changes to the UI
… name and pcap extension to pcap capture file. Updated UI colors for stopping captures
…e the captures array was getting set to null on page reloads. Minor UI cosmetic fixes
…ct total for the current number of displayed table items. Will need to look at the back end code to verify
…ll to GetVMInfo and made sure that the vm name was always passed to GetVMCaptures
I probably swapped some icons around. Also, there are several
buttons attached to the wrong handlers as placeholders namely memory
snapshot and screen capture/snapshot. I will change the "hdd-o" icon that
I used and put the "floppy-o" icon back for the "create backing image"
function. I will do that in the next push of UI changes. I will try to
keep the commits small and focused around a specific purpose.
Also, the button grouping that I did to conserve screen real estate was
just a placeholder for other ideas. It was simple to implement and it was
good enough as a temporary solution. I am interested in other ideas and
prototyping to see how things look. Also, please change other icons as you
see fit. I really do not like the current icons for the "redeploy, reset
state, and restart" functions. They are too similar.
…On Mon, Dec 7, 2020 at 7:55 AM zach-r-long ***@***.***> wrote:
Looks really good! I like the modify state solution, very elegant!
One Issue.
[image: image]
<https://user-images.githubusercontent.com/6519919/101353051-fe560c00-3860-11eb-897c-4a9372a40f46.png>
I believe this should be the create backing image and have the old icon.
Clicking it brings up the backing image creation UI.
[image: image]
<https://user-images.githubusercontent.com/6519919/101353221-3c533000-3861-11eb-9c3a-f8ec1d2d7901.png>
Otherwise *LOOKS GREAT*
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR7UOXZSV26QEUITKI6BUQ3STTGD7ANCNFSM4UMSVH5Q>
.
|
Ok, I pushed a new set of updates. Also, I believe that I restored the old icon of "floppy-o" for the create backing image/create disk snapshot function. I added a default handler for the placeholder buttons "create memory snapshot and record screenshot". If the order of the buttons is not to your liking, we can always re-arrange. Currently, the buttons are ordered by function. For example, the buttons associated with snapshots are grouped together. If you like the concept of button groups to conserve screen real estate, we can always add a button to represent a "snapshot" group. This of course assumes that we might add more buttons in the future. |