Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separating watir code into own gem. #9

Closed
KellyMahan opened this issue Apr 1, 2015 · 5 comments
Closed

Separating watir code into own gem. #9

KellyMahan opened this issue Apr 1, 2015 · 5 comments

Comments

@KellyMahan
Copy link

I'm working on my own automation making use of the Wink hub and api.

https://github.com/KellyMahan/winker

Until a proper SDK is usable I'd like to make use of just your watir code with a configurable callback url. Easiest way is just create a gem with an executable.

I am trying to make it as modular as possible. I already have the basic Winker gem written. The readme explains it pretty well.

Winker-Rails is in progress but not releasable yet. It will be web interface for setting up logic that wink doesn't provide for.

Winker-Voice which I haven't started yet, will be the ai for parsing text strings for the proper commands.

All that i'm lacking is an easy way to get the commands from the echo device is something like your watir code. I may even add some additional functionality for playing music as part of the automation.

If it's not something you have time for then I can create it and attribute it to you.

@zachfeldman
Copy link
Owner

Hey @KellyMahan , do what you'd like, but please attribute me and the alexaho.me project. Thanks!

@KellyMahan
Copy link
Author

Heres my first "working" version. Test it out take a look and let me know what you think.
https://github.com/KellyMahan/AmazonEchoJS

@zachfeldman
Copy link
Owner

Nice, two things though:

  1. It's @zachfeldman, not @zachfeldmon
  2. I don't think it's really fair to just credit me for the "original inspiration" of this project - I looked at your code and a lot of it is just copied and pasted from my watir-login file. Perhaps, "Majority of code written by @zachfeldman" might be more appropriate, or, "Portions of code written by @zachfeldman"?

@KellyMahan
Copy link
Author

Sorry about the misspelling. Updated the readme as well.

@zachfeldman
Copy link
Owner

No worries - this looks good @KellyMahan . Just like to get credit for my work if possible =). Nice job!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants