Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable timeouts #51

Merged
merged 2 commits into from
Jun 30, 2016

Conversation

mcolyer
Copy link

@mcolyer mcolyer commented Jun 14, 2016

@zachfeldman I found this useful for working with slow WordPress sites. Let me know if there's anything else I need to do to get it integrated.

@zachfeldman
Copy link
Owner

Hey @mcolyer thanks for the PR! Could you write a test for this? Once you do and tests pass locally, I will merge.

As an FYI, I am removing TravisCI from this repo because I no longer host test sites (too much wordpress spam, hacking, etc because of multi-versioned attack surfaces)

@mcolyer
Copy link
Author

mcolyer commented Jun 15, 2016

@zachfeldman I've added a short set of tests in e340be7.

@zachfeldman
Copy link
Owner

@mcolyer if you post a screenshot of all tests passing on your machine, I will merge. Otherwise will need a day or two to get setup again on mine! Sorry, it's been a while :/

@mcolyer
Copy link
Author

mcolyer commented Jun 15, 2016

It's probably faster for you to set it up. The tests in that file pass but
I didn't get the integration tests running.

@zachfeldman
Copy link
Owner

Hey @mcolyer sorry for the delay! Your tests pass for me so I'm going to merge this and deploy a new version of the gem. Thanks!

@zachfeldman zachfeldman merged commit 33f55bf into zachfeldman:master Jun 30, 2016
@mcolyer mcolyer deleted the configurable-timeouts branch June 30, 2016 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants