Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a four features to render_crumb #53

Merged
merged 17 commits into from Oct 20, 2013
Merged

Added a four features to render_crumb #53

merged 17 commits into from Oct 20, 2013

Conversation

bsa7
Copy link
Contributor

@bsa7 bsa7 commented Oct 20, 2013

Hi all!
Four features added.
1. Now, we can set each parameters individually for each crumb.
example:

add_crumb name, link, :li_class => "my_class"

2. Not render empty html_options for tags.
example:
in rendered output we have no tag class instead class=""
issue 35 solved
3. We can set each crumb on right or left side. That parameter :right_side define it.
example:

add_crumb support_link, {:right_side => true, :links => "/support", :li_right_class => "pull-right hidden-phone"}

4. Also, we can use a html in a crumb name. No more results as:

<a href="\"><a style"...">...</a></a>

when call:

add_crumb '<a style="...">Some text</a>'

but will be carefully, you are need to pass href parameter in a tag for a link.

@andrew
Copy link
Contributor

andrew commented Oct 20, 2013

Looks good, can you update the tests as well?

@bsa7
Copy link
Contributor Author

bsa7 commented Oct 20, 2013

Yes, i work on this problem.

@bsa7
Copy link
Contributor Author

bsa7 commented Oct 20, 2013

OK. Test updated and passed.

@andrew
Copy link
Contributor

andrew commented Oct 20, 2013

Excellent, thanks!

andrew added a commit that referenced this pull request Oct 20, 2013
Added a four features to render_crumb
@andrew andrew merged commit 5ee65f4 into zachinglis:master Oct 20, 2013
@andrew
Copy link
Contributor

andrew commented Oct 20, 2013

I'll try and get a new release out later today

@bsa7
Copy link
Contributor Author

bsa7 commented Oct 20, 2013

OK. I'm ready to work on possible bugs, send me a mail, if issues found.
With best regards,
Sergeij Belevskij
Tobolsk
Russia

2013/10/20 Andrew Nesbitt notifications@github.com

I'll try and get a new release out later today


Reply to this email directly or view it on GitHubhttps://github.com//pull/53#issuecomment-26675322
.

@andrew
Copy link
Contributor

andrew commented Oct 20, 2013

I've just published this as v1.8.0: https://rubygems.org/gems/crummy/versions/1.8.0

@bsa7
Copy link
Contributor Author

bsa7 commented Oct 20, 2013

Andrew!

2013/10/20 Andrew Nesbitt notifications@github.com

I've just published this as v1.8.0:
https://rubygems.org/gems/crummy/versions/1.8.0


Reply to this email directly or view it on GitHubhttps://github.com//pull/53#issuecomment-26676660
.

@bsa7
Copy link
Contributor Author

bsa7 commented Oct 20, 2013

Andrew!
I'm glad to see this gem has updated.

2013/10/20 Andrew Nesbitt notifications@github.com

I've just published this as v1.8.0:
https://rubygems.org/gems/crummy/versions/1.8.0


Reply to this email directly or view it on GitHubhttps://github.com//pull/53#issuecomment-26676660
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants