Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letters with accents on the subject field #19

Closed
nicolasguzca opened this issue May 29, 2015 · 10 comments · Fixed by #21
Closed

Letters with accents on the subject field #19

nicolasguzca opened this issue May 29, 2015 · 10 comments · Fixed by #21

Comments

@nicolasguzca
Copy link
Collaborator

I have notice when I try to send an email with a subject that has an accent ( qué, porqué, etc) it removes the letter.

I tried putting the accents like this &aacute and still had no luck

@zachlatta
Copy link
Owner

Hmm, odd. Also ran into similar issues sending to emails with accents in
them (ex. "Andrew Péna apena@example.com").

Not entirely sure what might be causing this, probably the email library
we're using or Go's built-in library (the latter would surprise me).

@zachlatta
Copy link
Owner

@jordan-wright any thoughts on this?

@zachlatta
Copy link
Owner

@jordan-wright ping?

@jordan-wright
Copy link
Collaborator

Whoa- my apologies, this notification slipped past me.

I think I've seen something like this before. I don't think we currently do anything in the way of unicode support in the subject line, or headers, which is probably what's causing this.

Let me go look at the RFC's to see the best way to handle this and work on adjustments to my library.

@zachlatta
Copy link
Owner

zachlatta commented Jul 6, 2015 via email

@jordan-wright
Copy link
Collaborator

Created email/#22. Looks like there is quite a bit of work to get this working correctly, so it'll take a bit of time. I'll keep that issue updated.

@nicolasguzca
Copy link
Collaborator Author

Thank you very much guys for the help!

@zachlatta
Copy link
Owner

@nicolasguzca seems like this should be fixed, now that jordan-wright/email#22 has been. Can you try again and let us know how it goes?

P.S. Thank you @jordan-wright!

@nicolasguzca
Copy link
Collaborator Author

Sure thing, I will test it this afternoon and I'll let you guys know. Thanks @zachlatta and @jordan-wright you guys rock!

@jordan-wright
Copy link
Collaborator

@zachlatta, I would suggest changing the version of email in use to the gopkg versioned instance to provide backwards compatibility. Specifically, I would use v1.1 (gopkg.in/jordan-wright/email.v1), since version 2 (the current version) is only compatible with Go version >= 1.5 due to the change to use the mime/quotedprintable package introduced in the stdlib.

Version 1.1 has the added utf-8 support in headers that @nicolasguzca is looking for 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants