Refactored to use @jordan-wright email package

[jordan-wright]

Hey there!

I appreciate you checking out my email package before, since it turned out there was a sneaky bug that I didn't catch! The issue was that, when sending the To field, I was just putting in the whole string, instead of just the address, which is required.

All fixed now! If you'd like, feel free to give this pull request a shot and see if it works a little better for you.

[jordan-wright]

This pull request also adds the ability to attach files as follows:

-attach file1.txt,file2.txt,etc.

[zachlatta]

Thanks! The primary reason I reverted 3f0665e was because, for whatever reason, my mail client has trouble parsing emails sent from your package.

I use sup. The entire message is loaded as an attachment.

Here's a gist with two examples messages. The first is with your package and doesn't parse correctly in sup. The second is gophermail and parses correctly in sup.

Here's what a properly parsed email looks like:

[jordan-wright]

Thanks for the update, Zach. You are correct, it does look like sup is having trouble parsing the message. Although, the only difference I can see in message structure is my (IMO preferred) use of quoted printable encoding instead of base64. I'm almost positive my encoding is according to the RFC, so I'm not sure where the discrepancy is.

I'll install sup, play around with it, and see what I can come up with. Until then, I'll open an issue on both my email and the sup repos to track it down together.

If you don't mind, can we keep this open for now, and I'll keep you posted with updates?

[jordan-wright]

Would you mind if I shared the gist you provided in both an issue in my email package as well as the issue in the sup repo?

[jordan-wright]

I believe I have this all fixed. Tl;dr - the problem was that I wasn't adding a Mime-Version header, which I have yet to see in the RFC's. Regardless, sup requires it, so it is all added now. Feel free to give it a shot with the updated package and see if that works for you! 😄

[zachlatta]

Merged! Thanks!