Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make:migration create option does NOT take the name of the table #21

Closed
micheleangioni opened this issue Apr 27, 2017 · 4 comments
Closed
Assignees
Labels
Milestone

Comments

@micheleangioni
Copy link
Contributor

Hi,
first of all, congratulations for the great work on this package.

The command php yarak make:migration create_users_table --create=users, present in the readme, does NOT work, since create is an option and cannot take values.

Instead php yarak make:migration create_users_table --create works, but it does not set the table name properly.

Please continue to develop Yarak, it can be of great value to the Phalcon community :)

@zachleigh
Copy link
Owner

@micheleangioni Thanks for all the interest in this package! I'm in the middle of a cross-country move at the moment so don't have my dev machine or reliable Internet. Once things have settled and the new place gets Internet (next week??) I'll go through all your issues and pull requests. Thanks again.

@micheleangioni
Copy link
Contributor Author

It's a great package :) Hope to see it always better! ;)

@zachleigh zachleigh self-assigned this May 3, 2017
@zachleigh zachleigh added the bug label May 3, 2017
@zachleigh zachleigh added this to the v1.1.2 milestone May 3, 2017
@zachleigh
Copy link
Owner

Forgot to add required argument flag ('=') when I rewrote the command using the new command syntax. Fix and add acceptance test.

@micheleangioni
Copy link
Contributor Author

Great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants