Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing loaders with webpack #4

Closed
goatslacker opened this issue May 16, 2015 · 10 comments
Closed

Allow customizing loaders with webpack #4

goatslacker opened this issue May 16, 2015 · 10 comments

Comments

@goatslacker
Copy link
Collaborator

Maybe if there is a webpack.config.js already present then use that instead?

@goatslacker
Copy link
Collaborator Author

The use case:

someone is using import 'foo.css' in there react module, now this won't work with reactview.

@zackify
Copy link
Owner

zackify commented May 16, 2015

Actually does work, I added the css loader, but I see your point. Good
idea.
On Sat, May 16, 2015 at 13:56 Josh Perez notifications@github.com wrote:

The use case:

someone is using import 'foo.css' in there react module, now this won't
work with reactview.


Reply to this email directly or view it on GitHub
#4 (comment).

@zackify
Copy link
Owner

zackify commented May 17, 2015

At that point, you might as well just use the webpack dev server don't you think? Maybe just pull in loaders from their config and that's it?

@goatslacker
Copy link
Collaborator Author

that could work

@RJ
Copy link

RJ commented May 18, 2015

doesn't quite work for me out of the box, i think because of extra features i've enabled with babel. reusing existing webpack config file makes sense imo.

@zackify
Copy link
Owner

zackify commented May 18, 2015

Can you post your config? I'm using stage 0 transforms already.
On Mon, May 18, 2015 at 04:15 Richard Jones notifications@github.com
wrote:

doesn't quite work for me out of the box, i think because of extra
features i've enabled with babel. reusing existing webpack config file
makes sense imo.


Reply to this email directly or view it on GitHub
#4 (comment).

@RJ
Copy link

RJ commented May 18, 2015

ah, i think it's because all my files are .js not .jsx, and your webpack requires jsx extension

@zackify
Copy link
Owner

zackify commented May 18, 2015

Yes thanks I will fix that today!
On Mon, May 18, 2015 at 08:18 Richard Jones notifications@github.com
wrote:

ah, i think it's because all my files are .js not .jsx, and your webpack
requires jsx extension


Reply to this email directly or view it on GitHub
#4 (comment).

@zackify
Copy link
Owner

zackify commented May 22, 2015

@RJ: @gaearon just pushed a fix for that, will publish to npm shortly. As for this issue, should I just hijack the loaders section of the webpack config?

@zackify
Copy link
Owner

zackify commented Aug 9, 2015

Should add this issues to https://github.com/insin/react-heatpack, I'm deprecating this project.

@zackify zackify closed this as completed Aug 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants