Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ammends SearchStocks Type #136

Merged
merged 1 commit into from Jan 16, 2021
Merged

Ammends SearchStocks Type #136

merged 1 commit into from Jan 16, 2021

Conversation

ArianZargaran
Copy link

Context

search Endpoint returns a Promise but declared as RawStockSearch instead. According to

What was done?

According to search tests, used as an async call, it's clear the Endpoint returns. a Promise.
https://github.com/zackurben/alphavantage/blob/master/test/data.js#L94

@coveralls
Copy link

Coverage Status

Coverage decreased (-77.0%) to 16.97% when pulling 41c29e1 on ArianZargaran:ammend-searchstocks-type into d7cb8d4 on zackurben:master.

@zackurben
Copy link
Owner

Thanks for the contribution, sorry for the delay!

@zackurben zackurben merged commit 841a76d into zackurben:master Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants