Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for symbol search endpoint (WIP) #58

Closed
wants to merge 2 commits into from

Conversation

2PacIsAlive
Copy link
Contributor

@2PacIsAlive 2PacIsAlive commented Apr 6, 2019

Hey I got the symbol search endpoint set up to address #48, having some trouble with travis not finding the api key and still figuring out what is up with the coverage report, I think this should be good to ship after those are set up :)

@coveralls
Copy link

coveralls commented Apr 6, 2019

Coverage Status

Coverage decreased (-25.0%) to 75.0% when pulling a3c7865 on 2PacIsAlive:master into b683537 on zackurben:master.

Add support for symbol search endpoint to README.

Add support for symbol search endpoint.
@zackurben
Copy link
Owner

@2PacIsAlive Thanks for the contribution! Let me take a look and I'll get back to you. The travis tests only run when I push, to protect the primary api key, so there is most likely no issues!

@zackurben zackurben mentioned this pull request Apr 10, 2019
@zackurben
Copy link
Owner

Closing in favor of #59 - Thanks again for your contribution, tests and coverage are passing 👍

@zackurben zackurben closed this Apr 10, 2019
zackurben added a commit that referenced this pull request Apr 10, 2019
@zackurben
Copy link
Owner

@2PacIsAlive This is available in alphavantage@1.2.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants