Extremely long validation time for complex object

[bzuillsmith]

Okay, if I validate this object it takes <1 ms.

{
    firstname: 'First',
    lastname: 'Last',
}

If I validate this object, it takes 32ms. What is happening that the ObjectID adds 31 ms processing time? Processing time goes up linearly, the more ObjectID's it has to check. Sometimes I need to check arrays of objects with ObjectIDs and that gets outrageous.

{
    _id: new ObjectID(),  // mongodb id
    firstname: 'First',
    lastname: 'Last',
}

[zaggino]

There's of course something very wrong going on in there - I'll look for a fix and let you know.

[zaggino]

@bzuillsmith can you give me a test-case with a schema you're testing against? Seems like inner properties of ObjectID() are being validated with your schema and that's causing the delay but I can't say for sure until I see the schema.

[bzuillsmith]

Below is an example test based on a subset of one of our use cases. Usually we add format: 'object-id that checks it's an instance of ObjectID but seems to make no difference to the problem.

On my machine, async validation takes 232ms and sync takes 200ms.

var ObjectID = require('mongodb').ObjectID;
var ZSchema = require('z-schema');

describe('z-schema', function() {
    var schema = {
        type: 'array',
        items: {
            type: 'object',
            properties: {
                'note': { type: 'string', maxLength: 2048 },
                // 'created':  { type: 'object', format: 'date-object' },
                'createdBy': { type: 'string', maxLength: 100 },
                '_id': { type: 'object' }
            },
            additionalProperties: false,
        },
        additionalItems: false,
    };

    var notes = [];

    before(function() {
        var num = 5, i;
        for(i = 0; i < num; i++) {
            notes.push({
                _id: new ObjectID(),
                note: 'Here is my note',
                createdBy: 'test@whatever.com',
            });
        }
        return notes;
    });

    it('should be fast', function(done) {
        var validator = new ZSchema({ async: true, noTypeless: true, noExtraKeywords: true, noZeroLengthStrings: true, forceAdditional: true});
        validator.validate(notes, schema, done);
    });
});

[zaggino]

@bzuillsmith here's the testcase I put together: ac4ed8c

I didn't notice any major difference with using ObjectID against using simple object. Btw on my computer validation over 10000 objects (I increased from your original five) took about 250ms in sync mode and 400ms in async mode.

Can you please try to run the testcase on your machine? Just clone the repo and do

npm install
npm install -g mocha
mocha --grep "issue/39"

[zaggino]

Confirmed solved in ac4ed8c#commitcomment-6674756