Skip to content

Commit

Permalink
ebml: crude hack to avoid crashing on unexpected metadata
Browse files Browse the repository at this point in the history
The comment says this cannot happen, but it did and I don't know
why. This is not the correct fix, needs investigation. Test case:
bug_s555010094_r0.0005:0.008____IA__g_assertion_message_expr.webm
  • Loading branch information
foolip authored and Sebastian Dröge committed May 19, 2010
1 parent 9c1267b commit c659c92
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions gst/matroska/matroska-demux.c
Original file line number Diff line number Diff line change
Expand Up @@ -3349,8 +3349,10 @@ gst_matroska_demux_parse_metadata (GstMatroskaDemux * demux)
GList *l;
GstEbmlLevel *curlevel;

/* Can't be NULL at this point */
g_assert (ebml->level != NULL);
if (ebml->level == NULL) {
GST_ERROR_OBJECT (demux, "Unexpected metadata, bailing");
return GST_FLOW_ERROR;
}
curlevel = ebml->level->data;

/* Make sure we don't parse a tags element twice and
Expand Down

0 comments on commit c659c92

Please sign in to comment.