Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for multiple wildcard words #46

Merged
merged 3 commits into from
Jan 26, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion changes/42.feature.rst

This file was deleted.

1 change: 1 addition & 0 deletions changes/46.fix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix issue with multiple wildcard words using standalone engine
2 changes: 1 addition & 1 deletion rita/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

logger = logging.getLogger(__name__)

__version__ = (0, 4, 0, os.getenv("VERSION_PATCH"))
__version__ = (0, 4, 1, os.getenv("VERSION_PATCH"))


def get_version():
Expand Down
20 changes: 11 additions & 9 deletions rita/engine/translate_standalone.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ def any_of_parse(lst, op=None):


def regex_parse(r, op=None):
return apply_operator(r, op)
initial = "(" + r + r"\s?" + ")"
return apply_operator(initial, op)


def not_supported(key, *args, **kwargs):
Expand All @@ -50,11 +51,7 @@ def punct_parse(_, op=None):


def word_parse(value, op=None):
if value:
initial = r"({})".format(value)
else:
initial = r"(\w+)"

initial = r"({}\s?)".format(value)
return apply_operator(initial, op)


Expand Down Expand Up @@ -98,7 +95,7 @@ def gen():
yield data[0]

for (t, d, op) in data[1:]:
if t != "punct":
if t not in ["punct", "word", "prefix"]:
yield ("whitespace", None, None)
yield (t, d, op)

Expand All @@ -119,15 +116,20 @@ def compile(self, label, rules):
if self.config.ignore_case:
flags = flags | re.IGNORECASE

return re.compile(r"(?P<{0}>{1})".format(label, "".join(rules)), flags)
regex_str = r"(?P<{0}>{1})".format(label, "".join(rules))
try:
return re.compile(regex_str, flags)
except Exception as ex:
logger.exception("Failed to compile: '{0}', Reason: \n{1}".format(regex_str, str(ex)))
return None

def _results(self, text):
for p in self.patterns:
for match in p.finditer(text):
yield {
"start": match.start(),
"end": match.end(),
"text": match.group(),
"text": match.group().strip(),
"label": match.lastgroup,
}

Expand Down
34 changes: 21 additions & 13 deletions tests/test_rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,13 +239,13 @@ def test_number(self):
rules = self.compiler('NUM("42")->MARK("SOME_NUMBER")')
print(rules)
assert len(rules) == 1
assert rules[0] == re.compile(r"(?P<SOME_NUMBER>(42))", self.flags)
assert rules[0] == re.compile(r"(?P<SOME_NUMBER>(42\s?))", self.flags)

def test_single_word(self):
rules = self.compiler('WORD("Test")->MARK("SOME_LABEL")')
print(rules)
assert len(rules) == 1
assert rules[0] == re.compile(r"(?P<SOME_LABEL>(Test))", self.flags)
assert rules[0] == re.compile(r"(?P<SOME_LABEL>(Test\s?))", self.flags)

def test_multiple_words(self):
rules = self.compiler('''
Expand All @@ -262,27 +262,27 @@ def test_simple_pattern(self):
''')
print(rules)
assert len(rules) == 1
assert rules[0] == re.compile(r"(?P<SIMPLE_PATTERN>(test1)[.,!;?:]?\s(test2))", self.flags)
assert rules[0] == re.compile(r"(?P<SIMPLE_PATTERN>(test1\s?)[.,!;?:]?\s(test2\s?))", self.flags)

def test_or_branch(self):
rules = self.compiler('''
{WORD("test1")|WORD("test2")}->MARK("SPLIT_LABEL")
''')
print(rules)
assert len(rules) == 2
assert rules[0] == re.compile(r"(?P<SPLIT_LABEL>(test1))", self.flags)
assert rules[1] == re.compile(r"(?P<SPLIT_LABEL>(test2))", self.flags)
assert rules[0] == re.compile(r"(?P<SPLIT_LABEL>(test1\s?))", self.flags)
assert rules[1] == re.compile(r"(?P<SPLIT_LABEL>(test2\s?))", self.flags)

def test_or_branch_multi(self):
rules = self.compiler('''
{WORD("test1")|WORD("test2"),WORD("test3")|WORD("test4")}->MARK("MULTI_SPLIT_LABEL")
''')
print(rules)
assert len(rules) == 4
assert rules[0] == re.compile(r"(?P<MULTI_SPLIT_LABEL>(test1)[.,!;?:]?\s(test3))", self.flags)
assert rules[1] == re.compile(r"(?P<MULTI_SPLIT_LABEL>(test2)[.,!;?:]?\s(test3))", self.flags)
assert rules[2] == re.compile(r"(?P<MULTI_SPLIT_LABEL>(test1)[.,!;?:]?\s(test4))", self.flags)
assert rules[3] == re.compile(r"(?P<MULTI_SPLIT_LABEL>(test2)[.,!;?:]?\s(test4))", self.flags)
assert rules[0] == re.compile(r"(?P<MULTI_SPLIT_LABEL>(test1\s?)[.,!;?:]?\s(test3\s?))", self.flags)
assert rules[1] == re.compile(r"(?P<MULTI_SPLIT_LABEL>(test2\s?)[.,!;?:]?\s(test3\s?))", self.flags)
assert rules[2] == re.compile(r"(?P<MULTI_SPLIT_LABEL>(test1\s?)[.,!;?:]?\s(test4\s?))", self.flags)
assert rules[3] == re.compile(r"(?P<MULTI_SPLIT_LABEL>(test2\s?)[.,!;?:]?\s(test4\s?))", self.flags)

def test_or_branch_multi_w_single(self):
rules = self.compiler('''
Expand All @@ -292,19 +292,19 @@ def test_or_branch_multi_w_single(self):
print(rules)
assert len(rules) == 4
assert rules[0] == re.compile(
r"(?P<MULTI_SPLIT_LABEL>(test1)[.,!;?:]?\s(one|three|two)[.,!;?:]?\s(test3))",
r"(?P<MULTI_SPLIT_LABEL>(test1\s?)[.,!;?:]?\s(one|three|two)[.,!;?:]?\s(test3\s?))",
self.flags
)
assert rules[1] == re.compile(
r"(?P<MULTI_SPLIT_LABEL>(test2)[.,!;?:]?\s(one|three|two)[.,!;?:]?\s(test3))",
r"(?P<MULTI_SPLIT_LABEL>(test2\s?)[.,!;?:]?\s(one|three|two)[.,!;?:]?\s(test3\s?))",
self.flags
)
assert rules[2] == re.compile(
r"(?P<MULTI_SPLIT_LABEL>(test1)[.,!;?:]?\s(one|three|two)[.,!;?:]?\s(test4))",
r"(?P<MULTI_SPLIT_LABEL>(test1\s?)[.,!;?:]?\s(one|three|two)[.,!;?:]?\s(test4\s?))",
self.flags
)
assert rules[3] == re.compile(
r"(?P<MULTI_SPLIT_LABEL>(test2)[.,!;?:]?\s(one|three|two)[.,!;?:]?\s(test4))",
r"(?P<MULTI_SPLIT_LABEL>(test2\s?)[.,!;?:]?\s(one|three|two)[.,!;?:]?\s(test4\s?))",
self.flags
)

Expand Down Expand Up @@ -334,3 +334,11 @@ def test_list_with_accent(self):
print(rules)
assert len(rules) == 1
assert rules[0] == re.compile(r"(?P<EXTENDED_LIST>(Jonas|Jurgis|Sarunas|Šarūnas))", self.flags)

def test_double_op(self):
rules = self.compiler('''
WORD+->MARK("DOUBLE_OP")
''')
print(rules)
assert len(rules) == 1
assert rules[0] == re.compile(r"(?P<DOUBLE_OP>(\w+\s?)+)", self.flags)