update!: support for fileCollection and guess the spectra type #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analysis-ui-components ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ghost
marked this pull request as draft
Codecov ReportBase: 91.85% // Head: 88.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 91.85% 88.39% -3.47%
==========================================
Files 8 8
Lines 491 491
Branches 80 79 -1
==========================================
- Hits 451 434 -17
- Misses 40 57 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lpatiny
added a commit
that referenced
this pull request
Oct 14, 2022
* update: support for fileCollection and classification of spectra * update: a few missing types, and prettify * test: disable temporarely getIVMeasurement * chore: rename files to fileCollection * chore: add todo to use FiltCollection.filter Co-authored-by: Luc Patiny <luc@patiny.com>
This was referenced Oct 14, 2022
Merged
lpatiny
added a commit
that referenced
this pull request
Oct 15, 2022
* wip: prepare cary500Loader * update!: support for fileCollection and guess the spectra type (#246) * update: support for fileCollection and classification of spectra * update: a few missing types, and prettify * test: disable temporarely getIVMeasurement * chore: rename files to fileCollection * chore: add todo to use FiltCollection.filter Co-authored-by: Luc Patiny <luc@patiny.com> * feat: add experimental cary500Loader * chore: update dependencies and add testcase * chore: add missing vitest import * chore: fix prettier Co-authored-by: Santiago Miranda <santimir@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error coming from the new parser version (biologic) so it needs fixing.
Fixings, style, comments, recommendations etc are welcome. 😃