Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update!: support for fileCollection and guess the spectra type #246

Merged
merged 6 commits into from Oct 14, 2022
Merged

update!: support for fileCollection and guess the spectra type #246

merged 6 commits into from Oct 14, 2022

Conversation

santifoo
Copy link
Member

@santifoo santifoo commented Oct 13, 2022

Error coming from the new parser version (biologic) so it needs fixing.
Fixings, style, comments, recommendations etc are welcome. 😃

@netlify
Copy link

netlify bot commented Oct 13, 2022

Deploy Preview for analysis-ui-components ready!

Name Link
🔨 Latest commit 4a9ab70
🔍 Latest deploy log https://app.netlify.com/sites/analysis-ui-components/deploys/6348e686ad3f1700098a7c25
😎 Deploy Preview https://deploy-preview-246--analysis-ui-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@santifoo santifoo marked this pull request as draft October 13, 2022 17:39
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Base: 91.85% // Head: 88.39% // Decreases project coverage by -3.46% ⚠️

Coverage data is based on head (4a9ab70) compared to base (37d42df).
Patch coverage: 77.27% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   91.85%   88.39%   -3.47%     
==========================================
  Files           8        8              
  Lines         491      491              
  Branches       80       79       -1     
==========================================
- Hits          451      434      -17     
- Misses         40       57      +17     
Impacted Files Coverage Δ
src/app/data/loaders/biologicLoader.ts 32.00% <28.57%> (-68.00%) ⬇️
src/app/data/DataState.ts 97.40% <100.00%> (ø)
src/app/data/append.ts 98.14% <100.00%> (ø)
src/app/data/loaders/jcampLoader.ts 84.61% <100.00%> (ø)
src/app/data/loaders/wdfLoader.ts 97.97% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lpatiny lpatiny marked this pull request as ready for review October 14, 2022 04:35
@lpatiny lpatiny merged commit 0bb78c5 into zakodium-oss:main Oct 14, 2022
lpatiny added a commit that referenced this pull request Oct 14, 2022
* update: support for fileCollection and classification of spectra

* update: a few missing types, and prettify

* test: disable temporarely getIVMeasurement

* chore: rename files to fileCollection

* chore: add todo to use FiltCollection.filter

Co-authored-by: Luc Patiny <luc@patiny.com>
@lpatiny lpatiny mentioned this pull request Oct 15, 2022
lpatiny added a commit that referenced this pull request Oct 15, 2022
* wip: prepare cary500Loader

* update!: support for fileCollection and guess the spectra type (#246)

* update: support for fileCollection and classification of spectra

* update: a few missing types, and prettify

* test: disable temporarely getIVMeasurement

* chore: rename files to fileCollection

* chore: add todo to use FiltCollection.filter

Co-authored-by: Luc Patiny <luc@patiny.com>

* feat: add experimental cary500Loader

* chore: update dependencies and add testcase

* chore: add missing vitest import

* chore: fix prettier

Co-authored-by: Santiago Miranda <santimir@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants