Factor out local forms functions

Add test to make sure pdfs are actually generated

src/core/pdfFiller/pdfHandler.ts

@@ -2,10 +2,12 @@ import { PDFDocument } from 'pdf-lib'
 import Fill from './Fill'
 import { fillPDF } from './fillPdf'
 
-export interface PDFDownloader {
-  (url: string): Promise<PDFDocument>
+export interface FileDownloader<T> {
+  (url: string): Promise<T>
 }
 
+export type PDFDownloader = FileDownloader<PDFDocument>
+
 export const downloadPDF: PDFDownloader = async (url) => {
   const download = await fetch(url)
   const buffer = await download.arrayBuffer()

src/core/tests/LocalForms.ts

@@ -0,0 +1,36 @@
+import { PDFDocument } from 'pdf-lib'
+import {
+  FileDownloader,
+  PDFDownloader
+} from 'ustaxes/core/pdfFiller/pdfHandler'
+import fs from 'fs/promises'
+import path from 'path'
+import { TaxYear } from 'ustaxes/data'
+
+const localPath = (url: string) => path.join(__dirname, '../../../public', url)
+
+export const localFiles: FileDownloader<Uint8Array> = (
+  url: string
+): Promise<Uint8Array> => fs.readFile(localPath(url))
+
+const compiledPDFs: { [key: string]: PDFDocument } = {}
+
+export const localPDFs =
+  (y: TaxYear): PDFDownloader =>
+  async (url: string): Promise<PDFDocument> => {
+    const fileUrl = `/forms/${y}/${url}`
+
+    const lookedUpAt = localPath(fileUrl)
+
+    if (lookedUpAt in compiledPDFs) {
+      return compiledPDFs[lookedUpAt]
+    }
+
+    const bytes = await localFiles(fileUrl)
+
+    const pdf = await PDFDocument.load(bytes.buffer)
+
+    compiledPDFs[lookedUpAt] = pdf
+
+    return pdf
+  }

src/forms/Y2019/tests/common/F1040.ts

@@ -9,7 +9,7 @@ import Form from '../../irsForms/Form'
 import { create1040 } from '../../irsForms/Main'
 import { isRight } from 'ustaxes/core/util'
 import * as arbitraries from 'ustaxes/core/tests/arbitraries'
-import { localPDFs } from './LocalForms'
+import { localPDFs } from 'ustaxes/core/tests/LocalForms'
 import fs from 'fs/promises'
 import path from 'path'
 import { PDFDocument } from 'pdf-lib'
@@ -20,9 +20,9 @@ export const log1040Err = async (
   err: any
 ): Promise<void> => {
   try {
-    const pdfs = await insertFormDataToPdfs(forms, localPDFs)
+    const pdfs = await insertFormDataToPdfs(forms, localPDFs('Y2019'))
     const saveDirName = `Errors ${new Date().getUTCHours()}:${new Date().getMinutes()}:${new Date().getSeconds()}`
-    const saveRoot = path.resolve(__dirname, '../../../logs/errors')
+    const saveRoot = path.resolve(__dirname, '../../../../../logs/errors')
     const saveDir = path.resolve(saveRoot, saveDirName)
     await fs.mkdir(saveDir, { recursive: true })
     await Promise.all(
@@ -65,7 +65,7 @@ export const with1040Pdfs = async (
 ): Promise<void> =>
   await with1040Assert(
     async ([, forms], info) => {
-      const pdfs = await insertFormDataToPdfs(forms, localPDFs)
+      const pdfs = await insertFormDataToPdfs(forms, localPDFs('Y2019'))
       f(pdfs, info)
     },
     logErr,
@@ -74,7 +74,7 @@ export const with1040Pdfs = async (
 
 export const with1040Property = (
   f: (f1040: [F1040, Form[]], info: Information) => Promise<void>,
-  year = 2020
+  year = 2019
 ): fc.IAsyncPropertyWithHooks<[Information]> =>
   fc.asyncProperty(
     new arbitraries.Arbitraries(year).information(),

src/forms/Y2019/tests/f1040.test.ts

@@ -1,4 +1,17 @@
 import { with1040Assert } from './common/F1040'
+import { yearFormBuilder } from 'ustaxes/forms/YearForms'
+import { isRight } from 'ustaxes/core/util'
+import { localPDFs } from 'ustaxes/core/tests/LocalForms'
+
+jest.setTimeout(40000)
+
+beforeAll(() => {
+  jest.spyOn(console, 'warn').mockImplementation((x: string) => {
+    if (!x.includes('Removing XFA form data as pdf-lib')) {
+      console.warn(x)
+    }
+  })
+})
 
 describe('f1040', () => {
   it('should be created in', async () => {
@@ -35,4 +48,17 @@ describe('f1040', () => {
       }
     })
   })
+
+  it('should create a PDF without failing', async () => {
+    await with1040Assert(async ([f1040]) => {
+      const forms = await yearFormBuilder('Y2019', f1040.info)
+        .setDownloader(localPDFs('Y2019'))
+        .build()
+        .f1040Pdfs()
+      expect(isRight(forms)).toEqual(true)
+      if (isRight(forms)) {
+        expect(forms.right).not.toHaveLength(0)
+      }
+    })
+  })
 })

src/forms/Y2020/tests/common/F1040.ts

@@ -9,7 +9,7 @@ import Form from '../../irsForms/Form'
 import { create1040 } from '../../irsForms/Main'
 import { isRight } from 'ustaxes/core/util'
 import * as arbitraries from 'ustaxes/core/tests/arbitraries'
-import { localPDFs } from './LocalForms'
+import { localPDFs } from 'ustaxes/core/tests/LocalForms'
 import fs from 'fs/promises'
 import path from 'path'
 import { PDFDocument } from 'pdf-lib'
@@ -20,9 +20,9 @@ export const log1040Err = async (
   err: any
 ): Promise<void> => {
   try {
-    const pdfs = await insertFormDataToPdfs(forms, localPDFs)
+    const pdfs = await insertFormDataToPdfs(forms, localPDFs('Y2020'))
     const saveDirName = `Errors ${new Date().getUTCHours()}:${new Date().getMinutes()}:${new Date().getSeconds()}`
-    const saveRoot = path.resolve(__dirname, '../../../logs/errors')
+    const saveRoot = path.resolve(__dirname, '../../../../logs/errors')
     const saveDir = path.resolve(saveRoot, saveDirName)
     await fs.mkdir(saveDir, { recursive: true })
     await Promise.all(
@@ -65,7 +65,7 @@ export const with1040Pdfs = async (
 ): Promise<void> =>
   await with1040Assert(
     async ([, forms], info) => {
-      const pdfs = await insertFormDataToPdfs(forms, localPDFs)
+      const pdfs = await insertFormDataToPdfs(forms, localPDFs('Y2020'))
       f(pdfs, info)
     },
     logErr,

src/forms/Y2020/tests/f1040.test.ts

@@ -1,5 +1,18 @@
+import { localPDFs } from 'ustaxes/core/tests/LocalForms'
+import { isRight } from 'ustaxes/core/util'
+import { yearFormBuilder } from 'ustaxes/forms/YearForms'
 import { with1040Assert } from './common/F1040'
 
+jest.setTimeout(40000)
+
+beforeAll(() => {
+  jest.spyOn(console, 'warn').mockImplementation((x: string) => {
+    if (!x.includes('Removing XFA form data as pdf-lib')) {
+      console.warn(x)
+    }
+  })
+})
+
 describe('f1040', () => {
   it('should be created in', async () => {
     await with1040Assert(async ([f1040, forms]) => {
@@ -35,4 +48,17 @@ describe('f1040', () => {
       }
     })
   })
+
+  it('should create a PDF without failing', async () => {
+    await with1040Assert(async ([f1040]) => {
+      const forms = await yearFormBuilder('Y2020', f1040.info)
+        .setDownloader(localPDFs('Y2020'))
+        .build()
+        .f1040Pdfs()
+      expect(isRight(forms)).toEqual(true)
+      if (isRight(forms)) {
+        expect(forms.right).not.toHaveLength(0)
+      }
+    })
+  })
 })

src/forms/Y2021/tests/common/F1040.ts

@@ -9,7 +9,7 @@ import Form from '../../irsForms/Form'
 import { create1040 } from '../../irsForms/Main'
 import { isRight } from 'ustaxes/core/util'
 import * as arbitraries from 'ustaxes/core/tests/arbitraries'
-import { localPDFs } from './LocalForms'
+import { localPDFs } from 'ustaxes/core/tests/LocalForms'
 import fs from 'fs/promises'
 import path from 'path'
 import { PDFDocument } from 'pdf-lib'
@@ -20,9 +20,9 @@ export const log1040Err = async (
   err: any
 ): Promise<void> => {
   try {
-    const pdfs = await insertFormDataToPdfs(forms, localPDFs)
+    const pdfs = await insertFormDataToPdfs(forms, localPDFs('Y2021'))
     const saveDirName = `Errors ${new Date().getUTCHours()}:${new Date().getMinutes()}:${new Date().getSeconds()}`
-    const saveRoot = path.resolve(__dirname, '../../../logs/errors')
+    const saveRoot = path.resolve(__dirname, '../../../../logs/errors')
     const saveDir = path.resolve(saveRoot, saveDirName)
     await fs.mkdir(saveDir, { recursive: true })
     await Promise.all(
@@ -65,7 +65,7 @@ export const with1040Pdfs = async (
 ): Promise<void> =>
   await with1040Assert(
     async ([, forms], info) => {
-      const pdfs = await insertFormDataToPdfs(forms, localPDFs)
+      const pdfs = await insertFormDataToPdfs(forms, localPDFs('Y2021'))
       f(pdfs, info)
     },
     logErr,

src/forms/Y2021/tests/f1040.test.ts

@@ -1,5 +1,18 @@
+import { localPDFs } from 'ustaxes/core/tests/LocalForms'
+import { isRight } from 'ustaxes/core/util'
+import { yearFormBuilder } from 'ustaxes/forms/YearForms'
 import { with1040Assert } from './common/F1040'
 
+jest.setTimeout(40000)
+
+beforeAll(() => {
+  jest.spyOn(console, 'warn').mockImplementation((x: string) => {
+    if (!x.includes('Removing XFA form data as pdf-lib')) {
+      console.warn(x)
+    }
+  })
+})
+
 describe('f1040', () => {
   it('should be created in', async () => {
     await with1040Assert(async ([f1040, forms]) => {
@@ -35,4 +48,17 @@ describe('f1040', () => {
       }
     })
   })
+
+  it('should create a PDF without failing', async () => {
+    await with1040Assert(async ([f1040]) => {
+      const forms = await yearFormBuilder('Y2021', f1040.info)
+        .setDownloader(localPDFs('Y2021'))
+        .build()
+        .f1040Pdfs()
+      expect(isRight(forms)).toEqual(true)
+      if (isRight(forms)) {
+        expect(forms.right).not.toHaveLength(0)
+      }
+    })
+  })
 })