use future to fund seeds in another thread #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaksabeast
reviewed
Feb 15, 2020
zaksabeast
approved these changes
Feb 15, 2020
There was a problem hiding this comment.
Great job, and thank you! 🎉 This was a good use of futures.
I also did the same with the applet, but async calculation there does not change anything so I didn't include it in this pull request.
For both, maybe we can include a moving "calculating" icon so that it gives some confidence that the overlay/applet has not frozen?
I agree; an indicator of some sort is needed in both the applet and overlay. I opened #25 for this. If you'd like to take it on, let me know! If not, that's alright too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #21.
I used C++ futures to calculate raid seed in async for the overlay. Now the game does not freeze when calculating the raid seed. Also due to a bug in tesla (or a weird interaction with capturesight overlay), hitting home button and then going back to the game gives control back to the player and you can actually play the game while the seed is being calculated.
I also did the same with the applet, but async calculation there does not change anything so I didn't include it in this pull request.
For both, maybe we can include a moving "calculating" icon so that it gives some confidence that the overlay/applet has not frozen?