Update to latest 2-16-19 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- gets focus test working properly - adds a no cancel button focus test this should prevent the regression in #17252 in the future
feat(platform): add mobileweb platform
fix(platform): add additional check for safari PWA
…17357) * docs(loading): remove dismissOnPageChange, change onDidDismiss to ionLoadingDidDismiss * docs(loading): add usage showing events
docs(loading): update example to show proper usage
* test(platform): add base platform tests * test(platform): add isPlatform test, clean up test file * test(platform): do not export matchMedia * test(platform): change window to win to avoid confusion
- updates css to allow for translucent tab-bar - adds translucent test
Fix some typos, clean up a code snippet, reword slightly to use clearer language (in consideration of ESL readers).
* add base reorder doc updates * update doc wording * remove extra sentence * clear up explanation sentence * fix typo * run build * fix doc definition for ionitemReorder * make requested changes * remove prop table
* update loading example * add async
…17474) * fix(searchbar): allow setting of toolbar color and searchbar color * fix test label typo
- MD PIN fixes not committed because they depend on mixin changes references #17012
* add button slot * add component slot docs * update content default slot description * run npm build * fix typos * update md files * docs(slots): update slot components and the build files * chore(stencil): updates stencil to build readmes * chore(build): update the swiper bundle file to match master * update default slot doc wording * revert changes * Revert "update default slot doc wording" This reverts commit e184014. merge * docs(slots): update default slot doc wording
…retOnScroll to boolean (#17302)
* feat(Range): add neutral point * feat(Range): generate proxies and api * fix(): check positive case in neutralPointChanged * fix(Range): neutralPoint to min if neutralPoint < min * fix(Range): active bar style * fix(Range): tick styling
* fix(Range): rtl support * fix(Range): knob position in rtl
…17492) * fix(item-sliding): Sliding no longer breaks after removing an item * run linter
* fix(datetime): default to current date when no value given * test(datetime): add spec test * move getDateValue to utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Changes proposed in this pull request:
Ionic Version:
Fixes: #