Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide possibility to add arbitrary query parameters to token request #39

Closed
bzums opened this issue Mar 9, 2017 · 0 comments · Fixed by #47
Closed

Provide possibility to add arbitrary query parameters to token request #39

bzums opened this issue Mar 9, 2017 · 0 comments · Fixed by #47
Assignees
@bzums
Labels
feature/enhancement
Milestone
Prepare for open-...

Comments

@bzums
Copy link
Collaborator

bzums commented Mar 9, 2017 •
edited
Loading

Currently, there is no way to add query parameters to a server request.
However, there are multiple use-cases:

Therefore, the OAuth config object (used in https://github.com/zalando-incubator/lib-oauth-tooling/blob/d222a021d20b2440d3662f0249dd1057fb50c23e/src/oauth-tooling.ts#L155) should be extended by an property queryParameters which accepts a HashMap of key value pairs which will be added to server requests.
@bzums bzums mentioned this issue Mar 9, 2017
Closed
@bzums bzums added this to the Prepare for open-sourcing milestone Mar 9, 2017
@bzums bzums mentioned this issue Mar 9, 2017
Closed
@bzums bzums self-assigned this Apr 18, 2017
@bzums bzums mentioned this issue Apr 18, 2017
Closed
@Retro64 Retro64 mentioned this issue Apr 19, 2017
Closed
bzums added a commit that referenced this issue Apr 25, 2017
@bzums
refactor(test): getTokenInfo spec
9d7c58c 
simplified test

see #39
bzums added a commit that referenced this issue Apr 25, 2017
@bzums
feat(api): optional query parameters
5be9821 
When requesting an access token (via `TokenCache` or via
`getAccessToken`) one can now specify an object `queryParams`
in the `OAuthConfig`. The given key-value pairs will be added
to the reuqest as query parameters.

`createAuthCodeRequestUri` accepts an optional parameter
`queryParams`. The given key-value pairs will be added to the
returned url string as query parameters.

close #39
@bzums bzums mentioned this issue Apr 25, 2017
Merged
bzums added a commit that referenced this issue Apr 25, 2017
@bzums
refactor(format): refactor based on review
59046eb 
see #39
bzums added a commit that referenced this issue Apr 25, 2017
@bzums
refactor(code): use spread operator
5f36701 
use spread instead of object.assign

see #39
@bzums bzums closed this as completed in #47 Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzums bzums

Labels
feature/enhancement
Projects
None yet
Milestone
Prepare for open-sourcing
Development

Successfully merging a pull request may close this issue.

39 query param support zalando-incubator/authmosphere
1 participant
@bzums