Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Zalando dependency REALM #40

Closed
bzums opened this issue Mar 9, 2017 · 0 comments · Fixed by #50
Closed

Remove Zalando dependency REALM #40

bzums opened this issue Mar 9, 2017 · 0 comments · Fixed by #50
Assignees
@bzums
Labels
feature/enhancement
Milestone
Prepare for open-...

Comments

@bzums
Copy link
Collaborator

bzums commented Mar 9, 2017

Currently, this lib can only be used with the Zalando OAuth server since a REALM is accepted in the OAuth config (used in https://github.com/zalando-incubator/lib-oauth-tooling/blob/d222a021d20b2440d3662f0249dd1057fb50c23e/src/oauth-tooling.ts#L155 and https://github.com/zalando-incubator/lib-oauth-tooling/blob/d222a021d20b2440d3662f0249dd1057fb50c23e/src/TokenCache.ts#L44).

It should be removed from the config. For Zalando internal use one should use the queryParameter option proposed in #39
@bzums bzums added this to the Prepare for open-sourcing milestone Mar 9, 2017
@bzums bzums mentioned this issue Mar 9, 2017
Closed
@Retro64 Retro64 mentioned this issue Apr 19, 2017
Closed
@bzums bzums self-assigned this Apr 27, 2017
bzums added a commit that referenced this issue Apr 27, 2017
@bzums
feat(open-source): become zalando-independent
9224a8e 
The (zalando-specific) `realm` property was removed from `OAuthConfig`.
Also, the corresponding constants (`SERVICES_REALM` and
`EMPLYEES_REALM`) were removed. Instead, you can add the realm (and
arbitrary other query parameters) via the `queryParams` property in
`OAuthConfig`.

close #40
@bzums bzums mentioned this issue Apr 27, 2017
Merged
bzums added a commit that referenced this issue May 2, 2017
@bzums
docs(improve-docs): fix markdown and docs
63a229f 
see #40
bzums added a commit that referenced this issue May 3, 2017
@bzums
docs(improve-docs): fix markdown and docs
415b692 
see #40
@bzums bzums closed this as completed in #50 May 3, 2017
bzums added a commit that referenced this issue May 3, 2017
@bzums
Merge pull request #50 from zalando-incubator/40-remove-zalando-depen…
becb7f3 
…dencies

feat(open-source): become zalando-independent

close #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzums bzums

Labels
feature/enhancement
Projects
None yet
Milestone
Prepare for open-sourcing
Development

Successfully merging a pull request may close this issue.

feat(open-source): become zalando-independent zalando-incubator/authmosphere
1 participant
@bzums