Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

More convienent way of making Hexo use the theme from node_modules? #112

Closed
Pizzacus opened this issue Jan 31, 2018 · 1 comment
Closed
Assignees
Milestone

Comments

@Pizzacus
Copy link

So, I was wondering, why do we have to make a symlink to install the theme? It's in order to get Hexo to use the theme from node_modules, right? So that the theme can be updated with npm, yarn or whatever

Well, wouldn't the same thing be achieved by setting the theme option to that folder directly?

Like this:

theme: ../node_modules/hexo-theme-doc

Because I did test it and it seems to be working, so I was wondering if you did consider this, maybe there are some "side effects" but as far as I can tell, it seems to be working, so I thought I would ask about it

rbarilani added a commit that referenced this issue Jan 31, 2018
Don't symlink `node_modules/hexo-theme-doc` as `themes/doc`.
Reference a relative path in the configuration file as `theme`
as suggested here: #112.
Remove ignore rules since not relevant anymore.

close #112
rbarilani added a commit that referenced this issue Jan 31, 2018
Don't symlink `node_modules/hexo-theme-doc` as `themes/doc`.
Reference a relative path in the configuration file as `theme`
as suggested here: #112.
Remove ignore rules since not relevant anymore.

close #112
rbarilani added a commit that referenced this issue Jan 31, 2018
Don't symlink `node_modules/hexo-theme-doc` as `themes/doc`.
Reference a relative path in the configuration file as `theme`
as suggested here: #112.
Remove ignore rules since not relevant anymore.

related to #112
@rbarilani rbarilani self-assigned this Jan 31, 2018
rbarilani added a commit that referenced this issue Jan 31, 2018
Don't symlink `node_modules/hexo-theme-doc` as `themes/doc`.
Reference a relative path in the configuration file as `theme`
as suggested here: #112.
Update ignore rules to ignore sub node_modules folder when `npm link`.

sh
@rbarilani rbarilani added this to the 1.2.0 milestone Feb 15, 2018
rbarilani added a commit that referenced this issue Feb 18, 2018
Don't symlink `node_modules/hexo-theme-doc` as `themes/doc`.
Reference a relative path in the configuration file as `theme`
as suggested here: #112.
Update ignore rules to ignore sub node_modules folder when `npm link`.

sh
@rbarilani
Copy link
Contributor

@Pizzacus Your suggestion was merged to the master branch, a release containing that change will be released soon, see 1.0.0-rc milestone

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants