added option to route traces traffic to local availability zone #4655
Conversation
|
|
||
| rewrite name exact {{ .ConfigItems.coredns_global_traces_endpoint }} {{ .ConfigItems.coredns_local_zone_traces_endpoint }} | ||
|
|
||
| kubernetes cluster.local { |
There was a problem hiding this comment.
We are a bit worried that having kubernetes defined both in this server block and below will double the memory for tracking kubernetes resources which would be a problem in big clusters.
Would you be able to verify if this is the case or not? Or alternatively merge it into a single server block to avoid defining the kubernetes block twice?
For context we have separate server blocks because of the guidance here: coredns/coredns#2593 (comment) it may need to be re-evaluated considering this new use-case.
There was a problem hiding this comment.
That makes sense, moved rewrite rule for traces endpoint into existed server, removed extra server
There was a problem hiding this comment.
Could you include the guidance from this comment?
There was a problem hiding this comment.
Not sure if I understand you correctly,
- Second server with a
kubernetesplugin was removed - I'm not touching
kubernetesplugin definition at all in the existed server, it stays the same - That enhancement you're referring to is probably a good case for individual ticket, testing (performance?) and individual pull request
There was a problem hiding this comment.
I mean I can replace
kubernetes {
pods insecure
}
with
kubernetes cluster.local 2.10.in-addr.arpa 3.10.in-addr.arpa {
pods insecure
}
but I'm not sure about the potential impact and it looks like not much related to the feature I'm implementing
|
👍 |
1 similar comment
|
👍 |
https://github.bus.zalan.do/teapot/issues/issues/3102