beta to stable #6377
Merged
beta to stable #6377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zalando-teapot-robot
commented
Aug 24, 2023
•
zalando-teapot-robot
commented
- Validation webhook for ingress (#6341)
- Make it possible to setup a custom etcd stack (#6375)
- skipper: configure terminationMessagePolicy (#6376)
- Include externalIngress port in stack definition. (#6381)
- skipper: add config to enable ingress validation webhook (#6384)
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
add initial deletion remove condition for webhook to work always with ingress at least Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
…r-ingress Validation webhook for ingress
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
* configure terminationMessagePolicy for hostname-credentials CronJobs to have last log messages in the pod status * update versions Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Make it possible to setup a custom etcd stack
|
Users reported a potential issue with the validation. We need to understand if this is an issue or not before rolling forward. |
Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com>
Signed-off-by: Rodrigo Reis <rodrigo.gargravarr@gmail.com>
…minationMessagePolicy skipper: configure terminationMessagePolicy
Similar to existing routegroups_validation. Tested that it works also when both are disabled: ``` ~$ kubectl get ValidatingWebhookConfiguration skipper-admitter.teapot.zalan.do NAME WEBHOOKS AGE skipper-admitter.teapot.zalan.do 0 27h ``` Followup on #6341 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
I propose we disable it #6384 and develop a better rollout plan. |
Include externalIngress port in stack definition.
|
Also do not update webhook version #6385 |
…ok-config skipper: add config to enable ingress validation webhook
Decided not to downgrade. |
|
👍 |
This validation has been disabled which is included now in the PR. So we're good to move forward. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.