Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipper: add config to enable ingress validation webhook #6384

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

AlexanderYastrebov
Copy link
Member

@AlexanderYastrebov AlexanderYastrebov commented Aug 24, 2023

Similar to existing routegroups_validation (hence plural).

Renamed manifest from routegroups-webhook.yaml to skipper-webhook.yaml.

Tested that it works also when both are disabled:

~$ kubectl get ValidatingWebhookConfiguration skipper-admitter.teapot.zalan.do
NAME                               WEBHOOKS   AGE
skipper-admitter.teapot.zalan.do   0          27h

Followup on #6341

Similar to existing routegroups_validation.

Tested that it works also when both are disabled:
```
~$ kubectl get ValidatingWebhookConfiguration skipper-admitter.teapot.zalan.do
NAME                               WEBHOOKS   AGE
skipper-admitter.teapot.zalan.do   0          27h
```

Followup on #6341

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@mikkeloscar
Copy link
Contributor

👍

AlexanderYastrebov added a commit that referenced this pull request Aug 24, 2023
Use version before #6341.
PR #6384 introduces config item for ingress validation.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov
Copy link
Member Author

👍

@AlexanderYastrebov AlexanderYastrebov merged commit bef7c68 into dev Aug 24, 2023
9 checks passed
@AlexanderYastrebov AlexanderYastrebov deleted the skipper/ingress-webhook-config branch August 24, 2023 15:06
This was referenced Aug 24, 2023
mikkeloscar pushed a commit that referenced this pull request Aug 25, 2023
Use version before #6341.
PR #6384 introduces config item for ingress validation.

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants