Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global option to enable/disable init containers and sidecars #478

Merged
merged 16 commits into from Dec 10, 2019

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Feb 4, 2019

Closes #464.
Error out on createStatefulSet, otherwise only warn whenever generateStatefulSet is called

@coveralls
Copy link

coveralls commented Feb 4, 2019

Coverage Status

Coverage remained the same at 23.705% when pulling c73d55e on feature/initcontainer_sidecar_toggle into 2e9b653 on master.

pkg/cluster/k8sres.go Outdated Show resolved Hide resolved
pkg/cluster/k8sres.go Outdated Show resolved Hide resolved
pkg/cluster/k8sres.go Outdated Show resolved Hide resolved
@Jan-M
Copy link
Member

Jan-M commented Feb 28, 2019

How do init containers work on scaling out for example or in? Is changing init containers reflected correctly in the manifest? (does it make sense to react on changes of init container on a running cluster)

But I agree with the above comment, if init is specced in manifest and globally disabled cluster should probably not be created. Modifying an existing one is something else.

@redbaron
Copy link
Contributor

redbaron commented Mar 4, 2019

How do init containers work on scaling out for example or in? Is changing init containers reflected correctly in the manifest? (does it make sense to react on changes of init container on a running cluster)

same as any other change to Stateful set's pod spec, it triggers graceful roll of all pods to new version of spec

@Jan-M
Copy link
Member

Jan-M commented Mar 4, 2019

Side car I get, but what is the value of having init containers added once the statefulset is already up and runing (I guess I need to read a bit more of K8S docs here). Maybe mixing a bit of "init of postgres" with "init of container environment"

@FxKu FxKu self-assigned this May 16, 2019
@FxKu FxKu added this to the v1.2 milestone May 20, 2019
@FxKu FxKu removed this from the v1.2 milestone Jun 28, 2019
@FxKu FxKu requested a review from RafiaSabih as a code owner July 22, 2019 09:17
@FxKu FxKu force-pushed the feature/initcontainer_sidecar_toggle branch from 19b29bd to 5fd53d0 Compare November 26, 2019 11:18
@FxKu FxKu added this to the v1.3 milestone Nov 29, 2019
docs/reference/operator_parameters.md Show resolved Hide resolved
pkg/cluster/resources.go Show resolved Hide resolved
pkg/cluster/k8sres.go Outdated Show resolved Hide resolved
go.sum Show resolved Hide resolved
docs/user.md Outdated Show resolved Hide resolved
@FxKu FxKu removed the needs review label Dec 2, 2019
@sdudoladov
Copy link
Member

👍

1 similar comment
@FxKu
Copy link
Member Author

FxKu commented Dec 10, 2019

👍

@FxKu FxKu merged commit 107334f into master Dec 10, 2019
@FxKu FxKu mentioned this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally enable init/sidecar containers
5 participants